Incorrect parse error detection

[AndrewKlopper]

At line 174 of Messages.cpp, you detect errors by checking if (used < size). However, if you call http_parser_execute with size of 0 (indicating EOF) it returns 1 to indicate an error (i.e., used > size). The check employed in the http_parser documentation is (used != size) for this reason.

[junfx]

Can anyone explain why call http_parser_execute here is needed?

        if (used < size)
        {
            if (error == HPE_PAUSED)
            {
                // Make sure the byte that triggered the pause
                // after the headers is properly processed.
                if (!myComplete)
                {
                    used += ::http_parser_execute
                        (&myParser, &mySettings, data+used, 1);
                }
            }
            ....

Why not just return used?

[AndrewKlopper]

I believe it is related to this issue nodejs/http-parser#97 which is how I found httpxx in the first place.

I suspect http_parser_pause() was only ever intended to be called in the on_message_complete callback, and calling in on_headers_complete prevents the last byte of the headers from being fully processed by the parser. As a result, the value of used is off by one byte until the additional call to http_parser_execute.

From: junfx [mailto:notifications@github.com]
Sent: 07 September 2016 09:10 AM
To: AndreLouisCaron/httpxx httpxx@noreply.github.com
Cc: AndrewKlopper andrew@klopper.name; Author author@noreply.github.com
Subject: Re: [AndreLouisCaron/httpxx] Incorrect parse error detection (#25)

Can anyone explain why call http_parser_execute here is needed?

    if (used < size)
    {
        if (error == HPE_PAUSED)
        {
            // Make sure the byte that triggered the pause
            // after the headers is properly processed.
            if (!myComplete)
            {
                used += ::http_parser_execute
                    (&myParser, &mySettings, data+used, 1);
            }
        }
        ....

Why not just return used?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #25 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AIDDHsvmXFtJGO0UMgnQfNEXt1n7YSaFks5qnmM0gaJpZM4JoUEt . https://github.com/notifications/beacon/AIDDHgS0IYUgRq-RirGXTeQOxzhhrHW_ks5qnmM0gaJpZM4JoUEt.gif