Skip to content

fix(ci): 修复 Clippy io_other_error,恢复 Quality 门禁 - #42

Merged
cursor[bot] merged 1 commit into
masterfrom
cursor/fix-clippy-io-other-error-9342
Aug 27, 2026
Merged

cursor[bot] merged 1 commit into
masterfrom
cursor/fix-clippy-io-other-error-9342

Conversation

@AnlangA

@AnlangA AnlangA commented Aug 27, 2026

Copy link
Copy Markdown
Owner

问题

master 上 Quality(以及被它阻塞的 v1.0.4 Release)全部失败。失败点不是覆盖率门槛,而是 Clippy -D warnings

error: this can be `std::io::Error::other(_)`
  --> src-tauri/src/commands/mcumgr.rs:1527
  = note: `-D clippy::io-other-error` implied by `-D warnings`

Frontend correctness 一直是绿的。Required quality gate 只是因为 Rust job 失败而失败。

这是 PR #39 引入的 MCUmgr reset-disconnect 单测写法触发的 lint,不是覆盖率/质量分数门槛,因此按 Clippy 建议改代码,而不是下调 -D warnings

改动

  • reset_without_an_ack_is_treated_as_the_device_dropping 改为 std::io::Error::other("device removed")
  • 更正 CONTRIBUTING.md 里过时的门禁描述(CI 并非 release-only;pre-commit 也不再跑 coverage / llvm-cov / E2E)
  • CHANGELOG.md Unreleased 记录这次修复

CI/CD 现状(分析)

门禁 何时跑 内容
quality.yml PR + master push + release 复用 前端 lint/format/architecture/tokens/build;Rust bindings/fmt/clippy -D warnings
release.yml vX.Y.Z tag 先跑 quality,再三平台打包、安装/启动/卸载冒烟、SBOM/签名/draft release
scheduled-audit.yml 每周一 pnpm audit + cargo audit
pre-commit 本地 toolchain + lint/format/architecture/build
pre-push 本地 上述 + frontend/Rust tests + browser E2E

覆盖率门槛已在 v1.0.1 从 CI 移除;本次失败与覆盖率无关。

本地验证

  • cargo clippy --manifest-path src-tauri/Cargo.toml --workspace --all-targets --all-features --locked -- -D warnings 通过
  • cargo test --manifest-path src-tauri/Cargo.toml --locked --lib reset_without_an_ack 通过

测试计划

  • GitHub Quality:Frontend correctness + Rust correctness + Required quality gate 全绿
Open in Web Open in Cursor 

Quality 与 Release 工作流因 clippy::io_other_error 失败。MCUmgr
reset-disconnect 测试改为 std::io::Error::other,并更正 CONTRIBUTING
中与实际 CI 门禁不符的描述。
@AnlangA
AnlangA marked this pull request as ready for review August 27, 2026 12:42
@cursor
cursor Bot merged commit a92364f into master Aug 27, 2026
3 checks passed
@AnlangA
AnlangA deleted the cursor/fix-clippy-io-other-error-9342 branch August 31, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants