fix(ci): 修复 Clippy io_other_error,恢复 Quality 门禁 - #42
Merged
Merged
Conversation
Quality 与 Release 工作流因 clippy::io_other_error 失败。MCUmgr reset-disconnect 测试改为 std::io::Error::other,并更正 CONTRIBUTING 中与实际 CI 门禁不符的描述。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
master上 Quality(以及被它阻塞的 v1.0.4 Release)全部失败。失败点不是覆盖率门槛,而是 Clippy-D warnings:Frontend correctness 一直是绿的。Required quality gate 只是因为 Rust job 失败而失败。
这是 PR #39 引入的 MCUmgr reset-disconnect 单测写法触发的 lint,不是覆盖率/质量分数门槛,因此按 Clippy 建议改代码,而不是下调
-D warnings。改动
reset_without_an_ack_is_treated_as_the_device_dropping改为std::io::Error::other("device removed")CONTRIBUTING.md里过时的门禁描述(CI 并非 release-only;pre-commit 也不再跑 coverage / llvm-cov / E2E)CHANGELOG.mdUnreleased 记录这次修复CI/CD 现状(分析)
quality.ymlmasterpush + release 复用-D warningsrelease.ymlvX.Y.Ztagscheduled-audit.ymlpnpm audit+cargo audit覆盖率门槛已在 v1.0.1 从 CI 移除;本次失败与覆盖率无关。
本地验证
cargo clippy --manifest-path src-tauri/Cargo.toml --workspace --all-targets --all-features --locked -- -D warnings通过cargo test --manifest-path src-tauri/Cargo.toml --locked --lib reset_without_an_ack通过测试计划