docs(shadow-api-detector): wire with-shadow-apis example into check explicitly - #106
Merged
Merged
Conversation
…xplicitly shadow-api-detector 1.0.0 no longer auto-wires detectShadowApis into check. Update the with-shadow-apis example to opt in explicitly so it keeps demonstrating a failing build, and bump its plugin version pin to 1.0.0. Verified with ./gradlew build against the published 1.0.0 plugin - the build still fails on the undocumented DELETE endpoint as described in the README. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectShadowApisopt-in rather than automatically wired intocheck/buildwith-shadow-apisexample demonstrates a failing build and relied on the old automatic wiring; it now adds the explicitdependsOnsnippet itselfshadow-api-detectorversion pin to the newly released1.0.0shadow-api-detectorexamples (clean,multi-file-openapi,openapi-3-2,request-mapping-composed) don't rely oncheck/buildwiring and are unaffected, so left out of scope here