Feature/issue 40 viewcomments permission - #41
Conversation
|
Dear Markus, thank you for submitting a PR for this new feature. We will take it under review. |
| mounted() { | ||
| // Only initialize selection events in regular page mode | ||
| if (!this.store.isSpecialPageMode) { | ||
| if (!this.store.isSpecialPageMode && this.userStore.canAddComments) { |
There was a problem hiding this comment.
it seems userStore isn't avaible here yet. the userStore should be returned inside the setup() function at line 81
|
|
||
| private function doListComments() { | ||
| if ( !$this->canViewComments() ) { | ||
| $this->addError( 'smartcomments-api-list-error-no-permission' ); |
There was a problem hiding this comment.
i've just noticed that the errors should be i18n strings but they are not. could you change this to be prefixed to sc-* just like other i18n and add it to the i18n files. i'll create a seperate mr where i fix the rest of the strings
| private static function canViewComments( \User $user ): bool { | ||
| return $user->isAllowed( self::PERMISSION_VIEW_COMMENTS ) || | ||
| $user->isAllowed( self::PERMISSION_MANAGE_COMMENTS ); | ||
| } |
There was a problem hiding this comment.
Can you make this backwards compatible? Anyone with add-inlinecomments should still be able to view comments and use Special:SmartComments like before. otherwise wikis with custom groups lose access on upgrade without any config change. So the view check should be view || add || manage
| ); | ||
| } | ||
|
|
||
| private function canViewComments(): bool { |
There was a problem hiding this comment.
3 participants
Pull request for #40.