Skip to content

soc: apple: {sep,aop}: log the endpoints and services the firmware offers #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brentkearney wants to merge 1 commit into
base: asahi-wip
Choose a base branch
from
+13 −7
Open

soc: apple: {sep,aop}: log the endpoints and services the firmware offers #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions drivers/soc/apple/aop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,12 @@ impl AopData {
b"las" => c_str!("las"),
b"als" => c_str!("als"),
_ => {
dev_info!(
self.dev,
"No driver for service {:?} on endpoint {}",
core::str::from_utf8(name),
ep.index
);
return Ok(());
}
};
Expand Down
14 changes: 7 additions & 7 deletions drivers/soc/apple/sep.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ const EP_BOOT: u64 = 0xFF;

const MSG_TYPE_SHIFT: u32 = 16;
const MSG_TYPE_MASK: u64 = 0xFF;
//const MSG_PARAM_SHIFT: u32 = 24;
//const MSG_PARAM_MASK: u64 = 0xFF;
const MSG_PARAM_SHIFT: u32 = 24;
const MSG_PARAM_MASK: u64 = 0xFF;

const MSG_EP_MASK: u64 = 0xFF;
const MSG_DATA_SHIFT: u32 = 32;
Expand Down Expand Up @@ -257,19 +257,19 @@ impl SepData {
}
fn process_discover_msg(&self, msg: Message) {
let ty = (msg.msg0 >> MSG_TYPE_SHIFT) & MSG_TYPE_MASK;
//let data = (msg.msg0 >> MSG_DATA_SHIFT) as u32;
//let param = (msg.msg0 >> MSG_PARAM_SHIFT) & MSG_PARAM_MASK;
let data = (msg.msg0 >> MSG_DATA_SHIFT) as u32;
let param = (msg.msg0 >> MSG_PARAM_SHIFT) & MSG_PARAM_MASK;
match ty {
MSG_ADVERTISE_EP => {
/*dev_info!(
dev_info!(
self.dev,
"Got endpoint {:?} at {}",
core::str::from_utf8(&data.to_be_bytes()),
param
);*/
);
}
_ => {
//dev_warn!(self.dev, "Unknown discovery message type: {}", ty);
dev_warn!(self.dev, "Unknown discovery message type: {}", ty);
}
}
}
Expand Down