shifted QR algorithm implementation for computing roots given coefficients by pasquale90 · Pull Request #3 · Audio-Project-Workgroup/digital_filter_visualiser

add prime implementation for calculating roots from coefficients based on the GramSchmidt method.

pasquale90

committed

improve extract roots method, symplifying it and making it more readable and maintainable. + added a todo as a comment for improving the data structure that stores the extracted roots in the upcomi…

pasquale90

committed

fix typo in CoefficientsToRoots::extractRoots method

pasquale90

committed

implement updating of the filter state on coefficient edits

pasquale90

committed

fix 4 bugs all at once.

pasquale90

committed

minor improvements and fixes:

pasquale90

committed

supress gcc warnings

pasquale90

committed

implement rayleigh quotient shift to speed up QR convergence

pasquale90

committed

fix 3 bugs:

pasquale90

committed

2 fixes:

pasquale90

committed

add documentation on CoefficientsToRoots class and change method name from GramSchmidt to QR

pasquale90

committed

clean print statements

pasquale90

committed

add tests for Coefficients2Roots::QR function (order computation only). An empirical tolerance variable is used allowing errors of 1 order per 4 orders (scaling per root)

pasquale90

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

shifted QR algorithm implementation for computing roots given coefficients#3

shifted QR algorithm implementation for computing roots given coefficients#3
pasquale90 wants to merge 16 commits into
masterfrom
coef2roots

Commits on Jun 13, 2026

add prime implementation for calculating roots from coefficients based on the GramSchmidt method.

improve extract roots method, symplifying it and making it more readable and maintainable. + added a todo as a comment for improving the data structure that stores the extracted roots in the upcomi…

fix typo in CoefficientsToRoots::extractRoots method

implement updating of the filter state on coefficient edits

fix 4 bugs all at once.

minor improvements and fixes:

supress gcc warnings

implement rayleigh quotient shift to speed up QR convergence

fix 3 bugs:

2 fixes:

add documentation on CoefficientsToRoots class and change method name from GramSchmidt to QR

clean print statements

add tests for Coefficients2Roots::QR function (order computation only). An empirical tolerance variable is used allowing errors of 1 order per 4 orders (scaling per root)

Commits on Jun 14, 2026

2 significant performance improvements applied (optimization and micro-optimization) :

apply micro-opt by replacing divisions with multiplications a) on the loop over subdiabonal elements and b) by avoiding double call of sqrt + replacing division with 2.0 by multipying with 0.5 inst…

skip updating of the filterstate in case that computed poles are violating causality constraint (at least one pole outside the unit circle - magnitude >= 1.0)