Skip to content

Single workflow#5

Draft
arkiev wants to merge 60 commits into
mainfrom
single_workflow
Draft

Single workflow#5
arkiev wants to merge 60 commits into
mainfrom
single_workflow

Conversation

@arkiev
Copy link
Copy Markdown

@arkiev arkiev commented Mar 19, 2026

The primary contribution of this fork is the addition of a complete DWI preprocessing and QC pipeline integrated as a first-class stage alongside the existing native contrast workflow. This includes automatic DICOM series classification, phase-encoding correction mode selection (rpe_none, rpe_pair, rpe_all, rpe_split), FSL-based DWI preprocessing via dwifslpreproc, tensor fitting to produce ADC and FA maps, and rigid-body T1-to-DWI coregistration using FLIRT — all orchestrated through a new pipeline.py entry point that runs all three stages from a single command. Several refinements were also made to the existing codebase: the ANTs registration check threshold was updated, vial masks are now transformed with nearest-neighbour interpolation to preserve binary values, and the ADC scatter plot was redesigned with open-circle reference markers plotted over the measured values for clearer visual comparison against SPIRIT reference data.

@arkiev arkiev requested a review from tclose March 19, 2026 23:26
@wiz-788c0877ba
Copy link
Copy Markdown

wiz-788c0877ba Bot commented Mar 19, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations 1 High 11 Medium 1 Low
SAST Finding SAST Findings 7 Medium
Software Management Finding Software Management Findings -
Total 1 High 18 Medium 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

arkiev added 3 commits March 20, 2026 10:50
…API change (plugin → worker) and Click's automatic underscore-to-hyphen conversion in option names (--metric_dir → --metric-dir).
@arkiev arkiev marked this pull request as ready for review March 20, 2026 01:49
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 14.41466% with 3129 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.17%. Comparing base (3216caf) to head (9865eb3).

Files with missing lines Patch % Lines
phantomkit/dwi_processing.py 0.00% 901 Missing ⚠️
phantomkit/phantom_processor.py 0.00% 720 Missing ⚠️
phantomkit/pipeline.py 0.00% 387 Missing ⚠️
phantomkit/plotting/calibration_plotter.py 14.57% 251 Missing and 1 partial ⚠️
phantomkit/plotting/compare_plots.py 11.16% 175 Missing ⚠️
phantomkit/plotting/vial_intensity.py 38.17% 136 Missing and 13 partials ⚠️
phantomkit/plotting/dwi_html.py 8.25% 100 Missing ⚠️
phantomkit/plotting/_html_common.py 57.52% 86 Missing and 10 partials ⚠️
phantomkit/cli.py 20.83% 76 Missing ⚠️
phantomkit/plotting/visualization.py 1.53% 64 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
- Coverage   68.73%   23.17%   -45.57%     
===========================================
  Files          12       21        +9     
  Lines        1206     4566     +3360     
  Branches      110      658      +548     
===========================================
+ Hits          829     1058      +229     
- Misses        350     3465     +3115     
- Partials       27       43       +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkiev and others added 4 commits April 17, 2026 14:30
Label derivation now finds the first path component that differs between
input files by walking inward from the right and identifying the common
suffix — surfaces the subject/session directory (e.g. P000009_testing)
rather than a shared scan-type directory (native_contrasts_staging).

Font sizes increased (axis titles 13→15px, ticks 12→14px, controls
11–12→14px); marker radii increased (session circles 6→9, reference
open circles 8→11, group mean squares 8→11); chart height 440→500px.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@arkiev arkiev marked this pull request as draft April 17, 2026 10:44
@arkiev arkiev self-assigned this Apr 17, 2026
arkiev and others added 24 commits April 20, 2026 14:30
Replaces the 5 separate per-metric CSV files (mean/median/std/min/max)
per contrast with a single .xlsx file containing one sheet per metric,
stored in metrics/xlsx/ instead of metrics/csv/.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants