Skip to content

use uuids for input schemes [SYNTH-251] - #1423

Open
0xda157 wants to merge 5 commits into
devfrom
dionkud/251/input-scheme-uuid
Open

use uuids for input schemes [SYNTH-251]#1423
0xda157 wants to merge 5 commits into
devfrom
dionkud/251/input-scheme-uuid

Conversation

@0xda157

@0xda157 0xda157 commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Task

SYNTH-251

Symptom

Solution

Verification

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157 0xda157 changed the title Dionkud/251/input scheme UUID uses uuids for input schemes [SYNTH-251] Jul 17, 2026
@0xda157 0xda157 changed the title uses uuids for input schemes [SYNTH-251] use uuids for input schemes [SYNTH-251] Jul 17, 2026
@0xda157
0xda157 force-pushed the dionkud/251/input-scheme-uuid branch 2 times, most recently from 5ad6157 to 761dd26 Compare July 17, 2026 17:03
This was referenced Jul 24, 2026
Merged
Open
@0xda157
0xda157 force-pushed the dionkud/251/input-scheme-uuid branch 3 times, most recently from 8accae3 to c577724 Compare July 24, 2026 20:50
@0xda157
0xda157 marked this pull request as ready for review July 24, 2026 20:51
@0xda157
0xda157 requested review from a team as code owners July 24, 2026 20:51
@0xda157

0xda157 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

no idea why the tests are failing, doesn't seem related to this pr

@PepperLola PepperLola added the refactor The most important part of software development. label Jul 24, 2026
@0xda157
0xda157 force-pushed the dionkud/251/input-scheme-uuid branch from 04397c9 to 82e480a Compare July 27, 2026 21:45
rutmanz
rutmanz requested changes Jul 31, 2026
View reviewed changes

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main purpose of this ticket was to fix the react state problems around how input schemes are referenced (the same ones you identified in your review of #1425). Now that we have unique IDs, the state can be the ID and then keep the scheme objects themselves isolated to the InputSchemeManager

Comment thread ...ion/src/ui/panels/configuring/assembly-config/interfaces/inputs/ConfigureSchemeInterface.tsx Outdated
Comment thread fission/src/ui/panels/configuring/initial-config/InputSchemeSelection.tsx Outdated
Comment thread fission/src/systems/input/InputSchemeManager.ts
})

return allSchemes
return [...this.customInputSchemes, ...this.defaultInputSchemes]

@rutmanz rutmanz Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different behavior from before, and will show both Ernie and customized Ernie, rather than just the customized one.

Image

@0xda157 0xda157 Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I asked azalea about that and she said not filtering out default schemes with the same name was a good idea, but I can revert that change.

@0xda157
0xda157 force-pushed the dionkud/251/input-scheme-uuid branch from 6255fc0 to fc7fc88 Compare July 31, 2026 17:07
@0xda157

0xda157 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@rutmanz soz about force pushing, I just wanted to make sure I merged correctly and I find that rebasing makes that a lot easier.

@Dhruv-0-Arora would be great if you could review this.

@0xda157
0xda157 requested a review from rutmanz July 31, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dhruv-0-Arora Dhruv-0-Arora Awaiting requested review from Dhruv-0-Arora Dhruv-0-Arora is a code owner automatically assigned from Autodesk/fission
@elliefre elliefre Awaiting requested review from elliefre elliefre is a code owner automatically assigned from Autodesk/fission
@PepperLola PepperLola Awaiting requested review from PepperLola PepperLola is a code owner automatically assigned from Autodesk/synthesis-admin
@rutmanz rutmanz Awaiting requested review from rutmanz

Requested changes must be addressed to merge this pull request.

Assignees

@0xda157 0xda157

Labels

refactor The most important part of software development.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xda157 @rutmanz @PepperLola