Premium Analytics: document widget conventions and Stats porting patterns#49987
Open
dognose24 wants to merge 4 commits into
Open
Premium Analytics: document widget conventions and Stats porting patterns#49987dognose24 wants to merge 4 commits into
dognose24 wants to merge 4 commits into
Conversation
…erns Consolidates conventions surfaced during code review of the Locations (#49513), Devices (#49928), and Search Terms (#49985) ports into shared agent guidance so future batch ports have a single source of truth. - `.agents/rules/widgets.md` — adds Two-component structure section (outer WidgetRoot / inner useWidgetRootContext, reportParams from context) - `AGENTS.md` — adds package-wide pitfalls (alias naming, English comments) and new Widget pitfalls (presentation source of truth, attribute type locality, button type, inline styles, toolkit helpers); new Stats widgets section covering data hooks, data access path, max=0 semantics, loading strategy, comparison placeholders, and visual conventions - `.agents/skills/widget-audit.md` — extends checklist with presentation consistency, ghost attributes, alias names, WidgetRenderProps<T> import, inline styles, button type, i18n scope, and English comments Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Code review on the Locations (#49513), Devices (#49928), and Search Terms (#49985) widget ports surfaced a set of recurring mistakes and missing patterns — attribute type locality, `presentation` source of truth, `max = 0` semantics, the two-component WidgetRoot structure, and more. This PR consolidates those into shared agent guidance so future batch ports have one source of truth instead of rediscovering them in review.
What
`.agents/rules/widgets.md`
`projects/packages/premium-analytics/AGENTS.md`
`.agents/skills/widget-audit.md`
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Documentation-only change — no runtime code is modified. To verify:
🤖 Generated with Claude Code