Render Premium Analytics inside the wp-admin shell#50010
Open
retrofox wants to merge 3 commits into
Open
Conversation
render inside the native wp-admin shell, not full-page
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
b63def3 to
63e9e8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
jetpack-premium-analytics-wp-admin) instead of the full-page slug. The page now renders inside the native wp-admin shell (sidebar + header) rather than the app taking over the whole screen via theadmin_initinterceptor.jpa_jetpack_premium_analytics_wp_admin_render_page()(frombuild/pages/jetpack-premium-analytics/page-wp-admin.php), guarded byfunction_exists()with a__return_nullfallback when the build is absent.?page=jetpack-premium-analytics; only the menu entry switches to the in-shell variant.Closes WOOA7S-1572
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack build packages/premium-analytics.?page=jetpack-premium-analytics-wp-admin&p=/loads the dashboard route.