Skip to content

Premium Analytics: update Locations selector size#50017

Draft
nerrad wants to merge 1 commit into
trunkfrom
codex/pa-locations-selectcontrol-size
Draft

Premium Analytics: update Locations selector size#50017
nerrad wants to merge 1 commit into
trunkfrom
codex/pa-locations-selectcontrol-size

Conversation

@nerrad

@nerrad nerrad commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

  • Add the WordPress Components 40px default size opt-in to the Premium Analytics Locations widget view selector.
  • Add a Premium Analytics changelog entry.

Related product discussion/links

  • None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • In a Premium Analytics local environment, open the dashboard page that renders the Locations widget.
  • Confirm the Locations widget's "View by" selector renders normally.
  • Confirm the browser console no longer logs the wp.components.SelectControl 36px default size deprecation warning for the Locations selector.
  • Run pnpm --filter @automattic/jetpack-premium-analytics typecheck.
  • Run pnpm --filter @automattic/jetpack-premium-analytics build.
  • Run pnpm --filter @automattic/jetpack-premium-analytics test.

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Premium Analytics [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant