Skip to content

Charts: Load GeoChart package explicitly#50018

Draft
nerrad wants to merge 1 commit into
trunkfrom
codex/premium-analytics-geochart-package
Draft

Charts: Load GeoChart package explicitly#50018
nerrad wants to merge 1 commit into
trunkfrom
codex/premium-analytics-geochart-package

Conversation

@nerrad

@nerrad nerrad commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

  • Load the Google geochart package explicitly when rendering @automattic/charts GeoChart, while preserving the react-google-charts default corechart and controls packages.
  • Add unit coverage to verify the GeoChart wrapper passes the expected Google Charts package list.
  • Add a patch changelog entry for @automattic/charts.

Related product discussion/links

  • None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Run pnpm --filter @automattic/charts test -- geo-chart.
  • Run pnpm --filter @automattic/charts typecheck.
  • Run pnpm --filter @automattic/charts build.
  • Run pnpm --filter @automattic/jetpack-premium-analytics typecheck.
  • Run pnpm --filter @automattic/jetpack-premium-analytics build.
  • Render the Premium Analytics Locations widget and confirm the Google Charts version warning is no longer emitted when GeoChart loads.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the codex/premium-analytics-geochart-package branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack codex/premium-analytics-geochart-package
bin/jetpack-downloader test jetpack-mu-wpcom-plugin codex/premium-analytics-geochart-package

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 26, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/js-packages/charts/src/charts/geo-chart/geo-chart.tsx 36/37 (97.30%) 0.08% 0 💚

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[JS Package] Charts RNA [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant