feat(donations): add option to flag any WooCommerce product as a donation by leogermani · Pull Request #4635 · Automattic/newspack-plugin

leogermani · 2026-04-06T20:44:56Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds the ability for publishers to flag any WooCommerce product as a donation. Currently, Newspack only supports a single grouped donation product (with one-time, monthly, and yearly children). This change allows publishers to create multiple distinct donation campaigns — e.g., "Support Local News" vs "Investigative Journalism Fund."

A "Donation product" checkbox is added to the WooCommerce product edit screen. When checked, the product inherits all existing donation behaviors: donation-specific checkout UI ("Donate now" button), coupon disabling, Stripe metadata labeling, reader activation handling, contribution meter tracking, and reporting exclusions.

The existing default donation product continues to work exactly as before — no migration is needed.

How to test the changes in this Pull Request:

Ensure WooCommerce and WooCommerce Subscriptions are active.
Go to Products > Add New and create a simple product.
In the Product Data panel, verify the "Donation product" checkbox appears alongside "Auto-complete orders."
Check the checkbox, save the product, and reload — verify the checkbox remains checked.
Uncheck the checkbox, save, and reload — verify it's unchecked.
Create a subscription product, check the "Donation product" checkbox, and save.
Add the flagged product to the cart and proceed to checkout — verify the checkout button says "Donate now" and coupons are disabled.
Complete a purchase of the flagged product and verify the order is recognized as a donation order (check Stripe metadata if Stripe is configured).
Verify the contribution meter block includes revenue from the flagged product.
Verify the default Newspack donation product (created via the Donations wizard) still works correctly and is unaffected.
Verify that trashing or deleting a flagged product does not cause errors.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

…t screen Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ation meta

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…filter Remove the Additional Donation Products section from the donations wizard, its REST endpoints, and TypeScript types. Add a Donation column and dropdown filter to the WooCommerce products list instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Use priority 20 to run after WooCommerce defines its columns, and use array_slice to insert before the last 2 columns (featured + date). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Adds support for marking arbitrary WooCommerce products as “donation products” so multiple distinct donation campaigns can share Newspack’s existing donation behaviors.

Changes:

Adds a “Donation product” boolean option to the WooCommerce product edit UI (persisted to product meta).
Extends donation detection and contribution meter revenue calculations to include meta-flagged donation products.
Adds unit tests for donation-product flag detection and retrieval.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`includes/plugins/woocommerce/class-woocommerce-products.php`	Adds the new WooCommerce product-type option/checkbox for donation flagging.
`includes/class-donations.php`	Updates donation-product detection, adds flagged-product ID query, and uses donation detection in cart logic.
`includes/contribution-meter/class-contribution-meter.php`	Includes flagged donation products when computing donation revenue.
`tests/unit-tests/donations.php`	Adds unit tests around donation flag behavior.
`includes/wizards/audience/class-audience-donations.php`	Minor formatting/indentation adjustment in wizard data payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

miguelpeixe

Tests well! I have a concern with the variable subscription setup:

miguelpeixe · 2026-04-13T18:43:14Z

+				'label'         => __( 'Donation product', 'newspack-plugin' ),
+				'description'   => __( 'Flag this product as a donation. Donation products use donation-specific checkout, reporting, and reader activation behaviors.', 'newspack-plugin' ),
+				'default'       => 'no',
+				'product_types' => [ 'simple', 'subscription', 'grouped', 'variable', 'variation', 'subscription_variation', 'variable-subscription' ],


For the variable-subscription type, I believe the flag should be inherited from the parent and not be applied to the single subscription_variation.

leogermani · 2026-04-29T13:48:50Z

@miguelpeixe addressed in b189cb4 (re: class-woocommerce-products.php:81).

Removed both subscription_variation and variation from the option's product_types so the checkbox only appears on parent products (variable, variable-subscription).
Updated is_donation_product() to walk up to the parent for variations so the flag is inherited.
Added tests covering both variation and subscription_variation inheritance plus the unflagged-parent case.

miguelpeixe · 2026-04-29T15:06:24Z

@leogermani I think you forgot to push

leogermani · 2026-04-29T16:07:22Z

@leogermani I think you forgot to push

oops. it's there now

leogermani and others added 12 commits April 6, 2026 17:32

feat(donations): add donation product flag checkbox to WC product edi…

4cb4a99

…t screen Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat(donations): update is_donation_product to check _newspack_is_don…

48822c7

…ation meta

feat(donations): include flagged products in contribution meter revenue

3249838

feat(donations): update is_donation_cart to support flagged products

6bc5776

feat(donations): add REST endpoints for flagged donation products

e7babac

feat(donations): add wizard UI for managing flagged donation products

9ba0391

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(donations): address code review feedback

e75c924

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(donations): insert donation column before date column

bb0401b

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(donations): fix column insertion priority and position

8ccdd2a

Use priority 20 to run after WooCommerce defines its columns, and use array_slice to insert before the last 2 columns (featured + date). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor(donations): remove donation column, keep only filter

6bd3cfc

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

refactor(donations): remove products list filter

5cbf0b5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

leogermani requested a review from Copilot April 6, 2026 20:49

Copilot started reviewing on behalf of leogermani April 6, 2026 20:49 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

leogermani added 4 commits April 7, 2026 15:27

fix: use woo functions to handle value

8da219c

chore: add memoization

6fd301b

fix: get all donation products

b9f9093

fix: consider all donations to get product from order

92b6344

leogermani self-assigned this Apr 7, 2026

leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 7, 2026

leogermani marked this pull request as ready for review April 7, 2026 19:00

leogermani requested a review from a team as a code owner April 7, 2026 19:00

miguelpeixe requested changes Apr 13, 2026

View reviewed changes

github-actions Bot added the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Apr 13, 2026

leogermani added 2 commits April 29, 2026 10:31

Merge branch 'trunk' into feat/donation-product-flag-v2

033b3aa

fix(donations): inherit donation flag from variable parent on variations

b189cb4

leogermani requested a review from miguelpeixe April 29, 2026 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(donations): add option to flag any WooCommerce product as a donation#4635

feat(donations): add option to flag any WooCommerce product as a donation#4635
leogermani wants to merge 18 commits intotrunkfrom
feat/donation-product-flag-v2

leogermani commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miguelpeixe left a comment

Uh oh!

miguelpeixe Apr 13, 2026

Uh oh!

leogermani commented Apr 29, 2026 •

edited

Loading

Uh oh!

miguelpeixe commented Apr 29, 2026

Uh oh!

leogermani commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leogermani commented Apr 6, 2026

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

miguelpeixe Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

leogermani commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miguelpeixe commented Apr 29, 2026

Uh oh!

leogermani commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leogermani commented Apr 29, 2026 •

edited

Loading