Pin Electron to 41.4.0 to fix macOS Keychain prompt regression#3601
Merged
Conversation
Electron 42 introduced a regression where ESM named imports touch the OS keychain on app.ready even when safeStorage is never called. This causes a macOS Keychain permission dialog to appear on every Studio launch. The fix (electron/electron#50419) targets Electron 43. Pin to 41.4.0 (exact, no range) until 43 ships.
Collaborator
📊 Performance Test ResultsComparing 063a5a0 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
fredrikekelund
approved these changes
May 22, 2026
Contributor
fredrikekelund
left a comment
There was a problem hiding this comment.
Installs cleanly. The app starts fine, and E2E tests are passing. LGTM 👍
I removed the devDependencies entry from the root package.json file, as that appeared to have been unintentional
Contributor
Author
Thanks. I added it as I couldn't start Electron after the downgrade without that - maybe I should just remove node_modules instead. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Used Claude Code to research the regression, identify the offending commit, and apply the fix.
Proposed Changes
electronfrom^42.1.0to exact41.4.0inapps/studio/package.jsonpackage-lock.jsonaccordinglyTesting Instructions
Context
Electron 42 introduced a regression (electron/electron#50419) where ESM named imports from
'electron'touch the OS keychain onapp.readyeven whensafeStorageis never called by app code. This causes a macOS Keychain permission dialog ("Electron wants to use your confidential information stored in 'Studio Safe Storage'") to appear on every launch.The fix is merged into Electron's
mainbranch (targeting Electron 43). Since no 42.x backport exists, we pin to 41.4.0 until Electron 43 ships.Pre-merge Checklist