Repository navigation
Conversation
With a Signer Name Field set and left empty, the audit trail took the name of the User whose address the signer typed into the email field. A guest could type another person's address and be recorded, and shown on the timeline card, under that User's name. A web form with a Signer Name Field now falls back to a User's name only when the signer's email is the logged-in user's own. Without one, the lookup is unchanged. Also say in the README, get_esign_link and send_esign_email that the link's email parameter is recorded as the signer's only on a web form without a Signer Email Field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SvdEeMiewirZ3ifFoUix5F
Member
Author
|
Superseded by #35, which removes the User-name fallback outright (the signer's name is recorded only as typed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up review fix for #33 (record a guest signer's name and email from the web form).
Change
With a Signer Name Field set but left empty,
_collect_audit_datafell back to the full name of the User whose address the signer typed into the Signer Email Field. That address is whatever the guest typed, so a guest could enter another person's address and be recorded, and shown on the timeline card as "Document signed by ", under the other person's name.Design
frappe.session.user). Otherwise no name is recorded.emailparameter is recorded as the signer's only on a web form without a Signer Email Field: README (Configuration,get_esign_linkunder "For developers", How It Works), theget_esign_linkdocstring and the comment insend_esign_email.No money, payroll, permission or migration paths are touched.
Verification
test_signer_fields_fall_back_when_empty_or_unsetnow checks both cases. A guest who types a User's address with an empty name gets no name, which fails on the old code (it recorded "esign-signer"). The same address while logged in as that User still gets the User's name.frappe-test --ci: 105 tests pass, coverage 98.5%, testmap complete, ty clean.prek run --all-filesis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01SvdEeMiewirZ3ifFoUix5F