Skip to content

java: impact says 'the change is local' about an entry point it just said the outside world calls #1467

Closed

Description

@swapnilpaliwal-sd

Symptom

impact on an entry point says "Changing it changes what the outside world can call", then ends with next: nothing resolved depends on it, so the change is local. The next: line is word for word the one given for a method nothing calls at all. Measured on 0.1.3 at 0df257c; CLI impact and the MCP axiomcode_impact tool print the same text.

Reproduction

A bare pom.xml and:

package app;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RestController;
@RestController
public class WidgetController {
    @GetMapping("/widgets/count")
    public int count() { return Widgets.count(); }
}
package app;
public class Widgets {
    public static int count() { return 1; }
    public static int spare() { return 2; }
}
$ axiomcode impact WidgetController.count
entry point: WidgetController.count is a http entry point -- a framework invokes it, so no client call site reaches it. Changing it changes what the outside world can call.
next: nothing resolved depends on it, so the change is local -- read src/main/java/app/WidgetController.java:6 and edit there
$ axiomcode impact Widgets.spare             # control: not an entry point, same next:
next: nothing resolved depends on it, so the change is local -- read src/main/java/app/Widgets.java:4 and edit there

A main method and a servlet doPost registered in web.xml give the same pair of lines.

Root cause

plugins/axiomcode/skills/axiomcode/scripts/axiomcode-impact: the entry-point line is printed at 1769 from ep_by_reason, but next: (lines 2133-2142) builds places from the contract and the direct dependents only, so an entry point with no in-graph caller takes the "change is local" branch at lines 2141-2142.

Expected: when the target is an entry point, next: says its callers are outside the graph and does not call the change local.

Activity

  1. added
    bugSomething isn't working
    skillAgent-facing query skill (skills/axiomcode)
    on Sep 28, 2026
  2. swapnilpaliwal-sd commented on Sep 28, 2026

    @swapnilpaliwal-sd
    ContributorAuthor

    Fixed by #1615, merged into 0.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingjavaJavaskillAgent-facing query skill (skills/axiomcode)

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions