Repository navigation
ci: build the platform engines once per release, on the push that lands it on main, and publish that build (#1350) - #1351
Merged
Conversation
…ds it on main, and publish that build (#1350) No pull request builds the platform engines any more. A push to main whose version has no tag yet builds every platform and runs the five-platform e2e; release.yml tags and drafts only after that run is green; publish-npm ships that run's engines and code-graph tarball instead of compiling again. A pull request into main may not reuse a released version, and a change that keeps main's version (CI, docs) builds nothing when it lands.
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 25, 2026 23:09
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1350.
A release built every platform's engines three times: on the pull request into main, on the push that landed it, and in publish-npm. Each is about 40 minutes of five runners, and the last meant the published binaries were not the ones the five-platform e2e tested.
v0.1.1 is already tagged and drafted by the previous flow; publishing it runs the publish-npm at that tag, which still rebuilds. The new flow starts with the next version.