Repository navigation
engine: resolve reads of module-level consts through their import binding - #1836
Merged
swapnilpaliwal-sd merged 2 commits intoSep 30, 2026
Conversation
…ding A module-scope const used as `X.m`, `f(X)`, in a template or under `typeof X` had no data edge to its declaration, so impact matched it by name, including same-named consts in sibling packages whose files import their own. - TypeScript and JavaScript engines export field_access rows for an identifier the binder ties to a module variable, directly or through an import binding (across `export *` barrels); `typeof X` type queries bind through module scope, with a same-named parameter or local shadowing it. - The bundle positions a field-access site that is a type reference. - impact: a const the engine bound on a route line is still a registration. - Goldens re-blessed: module consts read by name now carry known_edge reads. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 30, 2026 18:34
Contributor
Author
|
This conflicts with #1829 only in generated goldens: the |
The 78/80 goldens both sides regenerated are blessed again from the merged engine (the result differs from the integration tip by exactly this PR's rows), and the two 86 tests gain the reads this PR resolves (module consts read through their bindings); no resolved row is lost. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
deleted the
apps/typescript/imported-const-read-through-member-acces
branch
September 30, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A module-scope const read as
X.m,f(X), in a template or astypeof Xhad no edge to its declaration. So impact fell back to[by name], which also matched same-named consts in sibling packages that import their own.field_accessrows for an identifier bound to a module variable, either directly or through an import (includingexport *barrels). A const that holds a function is left to the call edges.typeof Xin a type is a read of X by the enclosing function, or by the module. A same-named parameter or local shadows it.86-module-variable-readswith controls (shadowing, sibling package, function const). Themodule-level-constcases are extended for TS and added for JS; without the rules 10 of 12 checks fail. Other goldens are re-blessed and 4 case expectations move from[by name]/[in scope]to[resolved].Checked: TS suite 100/100, JS 88/88; impact cases TS 214/214, JS 281/281, Java 306/306, Python 278/278, C# 207/207. On a 50k-LOC TS monorepo: call edges 10045 → 10045, resolved field access 2160 → 3562, index 27.2 s → 29.3 s, probes 47/74 → 47/74 (no regressions). The example const's impact went from 5
[by name]rows to 1 resolved row.