Repository navigation
impact --json answers in every form: no name answers the edits, a refusal is JSON (#1920) - #1921
Merged
Merged
Conversation
…al, as a document (#1920) impact --json with no name printed the usage text: only the front door answered for the working tree's edits. The dispatcher now sends it to ax_blocks edits-json: the impact document for the declarations the edits changed, with the edits under "edits" and a 'your edits:' line in its prose. A flag's value is not a name; --warm, --from-text and --delete keep the verb's own forms. impact <a name nothing declares> --json printed the refusal as plain text. In --json mode main() runs inside a redirect, and a refusal is printed as {targets: [], refusal, prose}. Case impact-json-without-a-name-answers-the-edits: --json parses for impact (named, no name, unknown), path (unknown), tests and context (no match); the no-name check fails on the base. Cases: python 445/445, typescript 352/352, javascript 354/354, java 374/374, csharp 319/319. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 11, 2026 01:31
When no changed declaration can be named (an edit outside any declaration, a fresh
checkout), test-impact printed its prose even under --json, so stdout did not parse:
the CI run of impact-json-without-a-name-answers-the-edits caught it. In --json mode
main() runs inside a redirect and a non-JSON answer is printed as
{changed: [], tests: [], prose}, exit code kept.
Cases: python 445/445, typescript 352/352, javascript 354/354, java 374/374,
csharp 319/319.
Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1920 — found by the 0.1.9 cross-platform release check.
impact --jsonwith no name printed the usage text; only the front door answered for the working tree's edits. It now answers with the impact document for the declarations the edits changed, plus"edits"(what changed) and ayour edits: …line inprose— the machine form of whatimpactwith no name shows at the front door. A flag's value is not taken for a name;--warm,--from-textand--deletekeep the verb's own forms.impact <unknown> --jsonprinted the refusal as plain text. It is now{"targets": [], "refusal": …, "prose": […]}with exit code 2.With #1912,
--jsonnow answers with a parseable document from every verb and form: path (known, unknown,'*'), impact (named, no name, unknown, with flags), tests / test-impact, context (match and no match), changed, link. The front door's text answers are unchanged.Case
impact-json-without-a-name-answers-the-edits(6 checks, allstdout_json); the no-name check fails on the base.Suites: python 445/445, typescript 352/352, javascript 354/354, java 374/374, csharp 319/319.