Skip to content

fix: error updating quotas #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
necronyxon wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: error updating quotas #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions modules/apim-adapter/src/main/java/com/axway/apim/adapter/apis/APIManagerQuotaAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,12 @@ public void saveQuota(APIQuota quotaConfig, String quotaId) throws AppException
int statusCode = httpResponse.getStatusCode();
String response = httpResponse.getResponseBody();
if (statusCode < 200 || statusCode > 299) {
if ((statusCode == 400) && (response.contains("API not found"))) {
LOG.warn("Got unexpected error: 'API not found' while saving quota configuration ... Try again in {} milliseconds. (you may set -retryDelay <milliseconds>)", cmd.getRetryDelay());
if ((statusCode == 400 && response.contains("API not found"))
|| (statusCode == 500 && response.contains("Internal server error"))
) {
LOG.warn("Got unexpected error while saving quota configuration ... Try again in {} milliseconds. (you may set -retryDelay <milliseconds>)", cmd.getRetryDelay());
Thread.sleep(cmd.getRetryDelay());
httpResponse = httpHelper.execute(request, true);
response = httpResponse.getResponseBody();
statusCode = httpResponse.getStatusCode();
if (statusCode < 200 || statusCode > 299) {
throw new AppException("Can't update API-Manager Quota-Configuration. Response: '" + response + "'", ErrorCode.API_MANAGER_COMMUNICATION);
} else {
LOG.info("Successfully created API-Access on retry. Received Status-Code: {}", statusCode);
}
retrySaveQuota(request);
} else {
throw new AppException("Can't update API-Manager Quota-Configuration. Response: '" + response + "'", ErrorCode.API_MANAGER_COMMUNICATION);
}
Expand All @@ -188,6 +183,17 @@ public APIQuota getDefaultQuota(Quota quotaType) throws AppException {
return quotaConfig;
}

private static void retrySaveQuota(RestAPICall request) throws IOException {
Response httpResponse = httpHelper.execute(request, true);
String response = httpResponse.getResponseBody();
int statusCode = httpResponse.getStatusCode();
if (statusCode < 200 || statusCode > 299) {
throw new AppException("Can't update API-Manager Quota-Configuration. Response: '" + response + "'", ErrorCode.API_MANAGER_COMMUNICATION);
} else {
LOG.info("Successfully created API-Access on retry. Received Status-Code: {}", statusCode);
}
}

private static APIQuota filterQuotaForAPI(APIQuota quotaConfig, API api) throws AppException {
List<QuotaRestriction> apiRestrictions = new ArrayList<>();
try {
Expand Down
Loading