feat(projects): cancel an in-flight project chat or analysis (#101) - #318
Open
Hustler490 wants to merge 1 commit into
Open
Hustler490 wants to merge 1 commit into
Hustler490 wants to merge 1 commit into
Conversation
|
@Hustler490 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Hustler490
force-pushed
the
feat/101-cancel-in-flight
branch
from
October 4, 2026 15:58
5b8132b to
9be7a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101.
What
Lets users cancel a running project chat stream or analysis.
Backend (
app/workspaces/routes.py)api_project_chat_streamnow accumulates the streamed tokens and:GeneratorExit) closes the upstream provider generator and stops without persisting a partial assistant message;BrokenPipeError/ConnectionResetError) stops cleanly with no partial write;chat_with_projectLLM call) and emits thedoneevent.The user message is still persisted up front.
Frontend (
project.html+project.js)AbortControlleron the streamfetch; analysis passes the same signal through the API helper. Aborts are treated as intentional (no error toast) and reset the UI.Tests (
tests/test_project_chat_cancel.py)iterator.close()) persists no assistant message, keeps the user message.done.Acceptance criteria
AbortController).