Fix database and container creation on serverless accounts by mkrueger · Pull Request #222 · Azure/CosmosDBShell

Mike Krüger (mkrueger) · 2026-09-25T08:59:17Z

Summary

Omit throughput from serverless ARM creation requests; reject explicit RU/scale settings with an actionable error.
On data-plane connections, retry without throughput only when the service reports a serverless throughput rejection, preserving provisioned-account defaults.
Cover database/container creation, ARM payloads, aliases, regression behavior, and an opt-in live serverless smoke test; update help and docs.

Fixes #218

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-code-quality · 2026-09-25T09:03:55Z

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall line coverage in commit 0311a6b in the dev/mkrueger/serverl... branch is 64%. The line coverage in commit c614f52 in the main branch is 63%.

Show a line coverage summary of the most impacted files.

File	`main` c614f52	`dev/mkrueger/serverl...` 0311a6b	+/-
`D:\a\CosmosDBSh...ughputErrors.cs`	100%	100%	0%
`D:\a\CosmosDBSh...osmosCommand.cs`	37%	39%	+2%
`D:\a\CosmosDBSh...sourceFacade.cs`	15%	27%	+12%
`D:\a\CosmosDBSh...ceOperations.cs`	3%	16%	+13%
`D:\a\CosmosDBSh...urceProvider.cs`	33%	62%	+29%
`D:\a\CosmosDBSh...ainerCommand.cs`	35%	85%	+50%
`D:\a\CosmosDBSh...reateCommand.cs`	26%	78%	+52%
`D:\a\CosmosDBSh...akeDbCommand.cs`	38%	92%	+54%
`D:\a\CosmosDBSh...onThroughput.cs`	0%	100%	+100%
`D:\a\CosmosDBSh...tedException.cs`	0%	100%	+100%

_{Updated September 27, 2026 19:14 UTC}

Copilot

Copilot review overview

🟡 Changes recommended

One or more issues must be addressed before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Narrow serverless throughput error retry detection · New

What changed in this PR

Fixes serverless database/container creation by omitting throughput when unspecified and rejecting explicit throughput settings, while preserving provisioned-account defaults.

Changes:

Added serverless detection and ARM payload handling.
Added data-plane retry logic and actionable errors.
Updated tests, documentation, localization, and smoke-test guidance.

File	Description
README.md	Updated as part of this pull request.
l10n/CosmosDBShell.json	Updated as part of this pull request.
docs/mcp.md	Updated as part of this pull request.
docs/commands.md	Updated as part of this pull request.
CosmosDBShell/lang/en.ftl	Updated as part of this pull request.
CosmosDBShell/Azure.Data.Cosmos.Shell.Core/ServerlessThroughputNotSupportedException.cs	Updated as part of this pull request.
CosmosDBShell/Azure.Data.Cosmos.Shell.Core/DataPlaneCosmosResourceOperations.cs	Updated as part of this pull request.
CosmosDBShell/Azure.Data.Cosmos.Shell.Core/CreationThroughput.cs	Updated as part of this pull request.
CosmosDBShell/Azure.Data.Cosmos.Shell.Core/CosmosArmResourceProvider.cs	Updated as part of this pull request.
CosmosDBShell/Azure.Data.Cosmos.Shell.Commands/MakeDbCommand.cs	Updated as part of this pull request.
CosmosDBShell/Azure.Data.Cosmos.Shell.Commands/MakeContainerCommand.cs	Updated as part of this pull request.
CosmosDBShell.Tests/Integration/ServerlessCreationSmokeTests.cs	Updated as part of this pull request.
CosmosDBShell.Tests/CommandTests/ServerlessCreationThroughputTests.cs	Updated as part of this pull request.
CONTRIBUTING.md	Updated as part of this pull request.
CHANGELOG.md	Updated as part of this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…ss-create-throughput

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Address the three unresolved moderate findings covering option handling, error classification, and smoke-test cleanup.

Review effort: Lite
Findings: 1

Open (1)

Restrict fallback to serverless throughput creation errors · New

Resolved since last review (1)

Narrow serverless throughput error retry detection

Copilot

Copilot review overview

🟡 Changes recommended

One or more issues must be addressed before approval.

Review effort: Lite
Findings: 1 · 1

Open (2)

Restrict fallback to serverless throughput creation errors
Use entity-neutral scale description for database creation · New

Resolved since last review (1)

Narrow serverless throughput error retry detection

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🔵 Needs a closer look

An unresolved issue allows whitespace-only --scale input to bypass explicit-option rejection; the smoke-test assertion is also overly broad.

Review effort: Lite
Findings: None

Resolved since last review (2)

Restrict fallback to serverless throughput creation errors
Use entity-neutral scale description for database creation

…tion Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🔵 Needs a closer look

One or more issues must be addressed before approval.

Review effort: Lite
Findings: None

Copilot

Copilot review overview

🟢 Approval recommended

The implementation consistently covers both creation paths with focused regression and payload tests.

Review effort: Balanced
Findings: None

Mike Krüger (mkrueger) · 2026-09-28T12:21:35Z

Copilot resolve the merge conflicts in this pull request

…ss-create-throughput Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>

Copilot · 2026-09-28T12:24:02Z

Copilot resolve the merge conflicts in this pull request

Merged the latest main into this branch. Git's ort strategy resolved everything automatically — no conflict markers were produced, including in the shared files (CosmosDBShell/lang/en.ftl, l10n/CosmosDBShell.json, docs/commands.md, README.md, CHANGELOG.md).

Verified after the merge:

dotnet build CosmosDBShell/CosmosDBShell.csproj — succeeded, 0 warnings/errors
dotnet test CosmosDBShell.Tests/CosmosDBShell.Tests.csproj --filter "Category!=Emulator" — 3181 passed, 0 failed (1 skipped: the opt-in live serverless smoke test)

Copilot

Copilot review overview

🟡 Changes recommended

The command documentation incorrectly claims data-plane explicit-throughput failures occur without sending a rejected request.

Review effort: Balanced
Findings: 1

Open (1)

Correct inaccurate claim about serverless fallback request behavior · New

+    --ru        Max RU/s (default: 1000)
 ```

+On provisioned accounts, omitting both options creates shared autoscale throughput with a maximum of 1000 RU/s. On serverless accounts, omit both options: the database is created without throughput settings, and supplying `--scale` or `--ru` fails with an explanation instead of sending a request the service rejects.


Mike Krüger (mkrueger) and others added 2 commits September 24, 2026 16:56

Omit creation throughput on serverless accounts (#218)

72f8df0

Complete serverless creation coverage and documentation

5c7d3eb

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Mike Krüger (mkrueger) requested review from a team and a lite review from Copilot September 25, 2026 08:59

Copilot started reviewing on behalf of Mike Krüger (mkrueger) September 25, 2026 08:59 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Comment thread CosmosDBShell/Azure.Data.Cosmos.Shell.Core/DataPlaneCosmosResourceOperations.cs Outdated

Mike Krüger (mkrueger) and others added 2 commits September 27, 2026 09:02

Merge remote-tracking branch 'origin/main' into dev/mkrueger/serverle…

93aa22a

…ss-create-throughput

Retry serverless creation only for throughput rejections

54b271c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 27, 2026 07:58

Copilot started reviewing on behalf of Mike Krüger (mkrueger) September 27, 2026 07:58 View session

Copilot AI reviewed Sep 27, 2026

View reviewed changes

Comment thread CosmosDBShell/Azure.Data.Cosmos.Shell.Core/ThroughputErrors.cs Outdated

Mike Krüger (mkrueger) requested a lite review from Copilot September 27, 2026 10:01

Copilot started reviewing on behalf of Mike Krüger (mkrueger) September 27, 2026 10:01 View session

Copilot AI reviewed Sep 27, 2026

View reviewed changes

Comment thread CosmosDBShell/lang/en.ftl

Tighten creation retry match and neutralize create scale help

0d52882

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 27, 2026 15:45

Copilot started reviewing on behalf of Mike Krüger (mkrueger) September 27, 2026 15:45 View session

Copilot AI reviewed Sep 27, 2026

View reviewed changes

Reject any supplied scale value on serverless and tighten smoke asser…

0311a6b

…tion Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 27, 2026 19:09

Copilot started reviewing on behalf of Mike Krüger (mkrueger) September 27, 2026 19:09 View session

Copilot AI reviewed Sep 27, 2026

View reviewed changes

Vsevolod Kukol (sevoku) requested a balanced review from Copilot September 28, 2026 11:24

Copilot started reviewing on behalf of Vsevolod Kukol (sevoku) September 28, 2026 11:24 View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Vsevolod Kukol (sevoku) approved these changes Sep 28, 2026

View reviewed changes

Mike Krüger (mkrueger) enabled auto-merge (squash) September 28, 2026 12:21

Copilot started work on behalf of Mike Krüger (mkrueger) September 28, 2026 12:21 View session

Merge remote-tracking branch 'origin/main' into dev/mkrueger/serverle…

dfee198

…ss-create-throughput Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 28, 2026 12:23

Copilot finished work on behalf of Mike Krüger (mkrueger) September 28, 2026 12:24

Copilot started reviewing on behalf of Mike Krüger (mkrueger) September 28, 2026 12:24 View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Navigation Menu

Fix database and container creation on serverless accounts - #222

Fix database and container creation on serverless accounts#222
Mike Krüger (mkrueger) wants to merge 7 commits into
mainfrom
dev/mkrueger/serverless-create-throughput

Mike Krüger (mkrueger) commented Sep 25, 2026 •

edited

Loading

Uh oh!

github-code-quality Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Mike Krüger (mkrueger) commented Sep 28, 2026

Uh oh!

Copilot AI commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Mike Krüger (mkrueger) commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

github-code-quality Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

C# / code-coverage/dotnet

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Mike Krüger (mkrueger) commented Sep 28, 2026

Uh oh!

Copilot AI commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mike Krüger (mkrueger) commented Sep 25, 2026 •

edited

Loading

github-code-quality Bot commented Sep 25, 2026 •

edited

Loading