Repository navigation
Modify exitcode returned when operating system check fails - #391
Merged
Merged
Conversation
Rajasi Rane (rane-rajasi)
requested review from
Koshy John (kjohn-msft) and
Mike Richmond (mirichmo)
as code owners
September 30, 2026 19:27
github-actions
Bot
requested review from
GAURAVRAMRAKHYANI,
SathishMSFT,
Michelle McDaniel (michellemcdaniel),
nikhim-um and
yashnap
September 30, 2026 19:27
Copilot started reviewing on behalf of
Rajasi Rane (rane-rajasi)
September 30, 2026 19:28
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Linux-specific setup can fail before OS validation, causing unsupported hosts to still return HandlerFailed.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates install handling to propagate the unsupported operating-system exit code and report it in status output.
Changes:
- Returns exit code 51 for unsupported platforms.
- Adds exit-code details to failed install statuses.
- Expands install and status tests.
| File | Description |
|---|---|
src/extension/src/InstallCommandHandler.py |
Propagates OS validation failures. |
src/extension/src/ActionHandler.py |
Records install exit codes in status messages. |
src/extension/tests/Test_InstallCommandHandler.py |
Tests unsupported-platform handling. |
src/extension/tests/Test_ActionHandler.py |
Tests install return codes and statuses. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 113 113
Lines 21936 21955 +19
=======================================
+ Hits 20835 20855 +20
+ Misses 1101 1100 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Koshy John (kjohn-msft)
approved these changes
Oct 1, 2026
Michelle McDaniel (michellemcdaniel)
approved these changes
Oct 2, 2026
Contributor
|
Please add testing logs for this. |
Koshy John (kjohn-msft)
pushed a commit
that referenced
this pull request
Oct 2, 2026
This release contains: - Modify exitcode returned when operating system check fails: [391](#391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests:
It's difficult to test this E2E on a VM. Since the error is in install command, GA re-downloads extension bits for each new API call. So manually modifying code bits on a VM doesn't work. I did validate by manually invoking install command but it won't go through e2e since it isn't an API call.
Validated by manually editing the extension file and adding a few additional log statements that aren't in code:
