Skip to content

chore(vscode): Cleanup dead code (#9341) [hotfix/v5.961]#9354

Merged
lambrianmsft merged 1 commit into
Azure:hotfix/v5.961from
lambrianmsft:cherry-pick/v5.961/9341
Jul 2, 2026
Merged

chore(vscode): Cleanup dead code (#9341) [hotfix/v5.961]#9354
lambrianmsft merged 1 commit into
Azure:hotfix/v5.961from
lambrianmsft:cherry-pick/v5.961/9341

Conversation

@lambrianmsft

@lambrianmsft lambrianmsft commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Byte-for-byte cherry-pick of #9341 (333b4d55) — dead-code cleanup.

  • git cherry-pick onto the hotfix tip: 17 files, 0 conflicts, no graphify artifacts involved.
  • 13 files deleted, 4 modified (createWorkflow.ts, cloudToLocalUtils.ts, constants.ts, main.ts); removal hunks applied faithfully. Residual diffs vs main in constants.ts/main.ts are expected hotfix base-divergence.

Part of the sequential hotfix cherry-pick series (9294 → 9330 → 9341 → 9289).

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Clean up dead/unreferenced code from vs-code-designer project related to old creation flow for project workspaces and workflows.

Impact of Change

  • Users: N/A
  • Developers: Remove unused code
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: chore(vscode): Cleanup dead code (#9341) [hotfix/v5.961]
  • Issue: No blocking issue. The title is descriptive, includes the scope, and matches the change.
  • Recommendation: None required.

Commit Type

  • Properly selected (chore).
  • Only one commit type is checked, which is correct.

Risk Level

  • The selected risk level (Low) matches the change and the diff. This is a dead-code cleanup/cherry-pick with deletions and a small behavior-neutral tweak, so low risk is appropriate.

What & Why

  • Current: Clean up dead/unreferenced code from vs-code-designer project related to old creation flow for project workspaces and workflows.
  • Issue: Clear and concise; sufficient for this PR.
  • Recommendation: None required.

Impact of Change

  • Reasonable for a cleanup PR.
  • Recommendation:
    • Users: N/A is acceptable.
    • Developers: Removing unused code is correctly noted.
    • System: N/A is acceptable.

Test Plan

  • Automated tests are not required here because the change is effectively code cleanup with no new functionality, and the PR body already indicates manual testing.
  • The diff also shows no active behavior additions that would require a new unit/E2E test for the PR body to be compliant.

Contributors

  • Included (@andrew-eldridge).
  • Not required, but good to have.

Screenshots/Videos

  • Not applicable for this change.

Summary Table

Section Status Recommendation
Title
Commit Type
Risk Level
What & Why
Impact of Change
Test Plan
Contributors
Screenshots/Videos

This PR passes review. The advised risk level remains low and matches the submitter's estimate.


Last updated: Thu, 02 Jul 2026 01:23:51 GMT

@lambrianmsft lambrianmsft added risk:low Low risk change with minimal impact and removed needs-pr-update labels Jul 2, 2026
@lambrianmsft lambrianmsft enabled auto-merge (squash) July 2, 2026 01:24
@lambrianmsft lambrianmsft merged commit d20ec3b into Azure:hotfix/v5.961 Jul 2, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants