Skip to content

chore(vscode): Cleanup dead code (#9341) [hotfix/v5.970]#9355

Merged
lambrianmsft merged 1 commit into
Azure:hotfix/v5.970from
lambrianmsft:cherry-pick/v5.970/9341
Jul 2, 2026
Merged

chore(vscode): Cleanup dead code (#9341) [hotfix/v5.970]#9355
lambrianmsft merged 1 commit into
Azure:hotfix/v5.970from
lambrianmsft:cherry-pick/v5.970/9341

Conversation

@lambrianmsft

@lambrianmsft lambrianmsft commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Byte-for-byte cherry-pick of #9341 (333b4d55) — dead-code cleanup.

  • git cherry-pick onto the hotfix tip: 17 files, 0 conflicts, no graphify artifacts involved.
  • 13 files deleted, 4 modified (createWorkflow.ts, cloudToLocalUtils.ts, constants.ts, main.ts); removal hunks applied faithfully. Residual diffs vs main in constants.ts/main.ts are expected hotfix base-divergence.

Part of the sequential hotfix cherry-pick series (9294 → 9330 → 9341 → 9289).

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Clean up dead/unreferenced code from vs-code-designer project related to old creation flow for project workspaces and workflows.

Impact of Change

  • Users: N/A
  • Developers: Remove unused code
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: chore(vscode): Cleanup dead code (#9341) [hotfix/v5.970]
  • Issue: No blocking issue. The title is specific and clearly describes the change.
  • Recommendation: None required.

Commit Type

  • Properly selected (chore).
  • Only one commit type is checked, which is correct.

Risk Level

  • The selected risk level (Low) matches the diff. This is a dead-code cleanup/cherry-pick with deletions and a small refactor in createWorkflow.ts/cloudToLocalUtils.ts.
  • Advised risk level: Low (same as submitted).

What & Why

  • Current: Clean up dead/unreferenced code from vs-code-designer project related to old creation flow for project workspaces and workflows.
  • Issue: No blocking issue. Brief but sufficient.
  • Recommendation: If desired, you could mention this is a cherry-pick of #9341, but it is not required.

Impact of Change

  • Good high-level impact summary for a cleanup PR.
  • Recommendation:
    • Users: N/A is acceptable for this cleanup.
    • Developers: Remove unused code is accurate.
    • System: N/A is acceptable.

Test Plan

  • The diff includes no new automated tests, but this is still acceptable because the PR is a cleanup/deletion-only change and the body clearly marks Manual testing completed.
  • This satisfies the test-plan rules for non-feature maintenance work.

Contributors

  • @andrew-eldridge is provided.
  • Recommendation: None required.

⚠️ Screenshots/Videos

  • Not provided.
  • Assessment: Acceptable, since this is not a visual/UI change.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors None
Screenshots/Videos ⚠️ Optional for non-visual changes

This PR passes. The submitted risk level matches the diff, and no body corrections are required.


Last updated: Thu, 02 Jul 2026 01:15:27 GMT

@lambrianmsft lambrianmsft enabled auto-merge (squash) July 2, 2026 01:23
@lambrianmsft lambrianmsft merged commit 665d9c7 into Azure:hotfix/v5.970 Jul 2, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants