fix(designer-v2): prevent false unsaved-changes flag in monitoring view

[rllyy97]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

Fixes #9345.

While viewing run history (read-only / monitoring view), the designer could be falsely marked dirty, producing an intermittent "your unsaved edits will be discarded" prompt when toggling back to the workflow/code view — even though the view is read-only and no edits were made.

Root cause: Monitoring view is read-only, but nothing guarded the isDirty flags against side-effects. A controlled parameter editor re-emitting its value on mount can trigger a parameter-update path that forces isUserAction: true → workflow.isDirty = true. Because it depends on parameter content and async timing, it reproduces only "sometimes", and the flag then persists so the host navigation guard shows the discard prompt.

Fix: Add monitoringDirtyGuardMiddleware to the designer-v2 store. While designerOptions.readOnly or isMonitoringView is set, it reverts any false → true transition of workflow.isDirty / workflowParameters.isDirty. This is root-cause-agnostic (covers parameter, settings, connection, and any other side-effect path) and preserves genuine pre-existing edits — only false → true transitions are reverted; already-true flags are left untouched.

Scoped to designer-v2 only. Designer v1 is intentionally left unchanged since v2 is replacing v1 in production.

Impact of Change

• Users: No more spurious "unsaved edits will be discarded" prompt when leaving run history in read-only/monitoring view. Genuine unsaved edits made before entering monitoring are still preserved and still prompt.
• Developers: New store middleware monitoringDirtyGuardMiddleware in libs/designer-v2/src/lib/core/utils/middleware.ts, wired after storeStateHistoryMiddleware. Follows the existing dispatch-from-middleware pattern.
• System: Negligible overhead — reads two booleans before/after each action and only dispatches when a guarded false→true transition occurs in read-only/monitoring mode.

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in: libs/designer-v2 Vitest suite — 24/24 passing in middleware.spec.ts (7 new tests: reverts false→true when readOnly; reverts when isMonitoringView; reverts both workflow and workflowParameters flags; preserves pre-existing true; no revert when editable; no dispatch when unchanged; transparent pass-through to next). Biome clean on all changed files.

Contributors

@rllyy97

Screenshots/Videos

N/A — behavioral fix, no UI changes.

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: fix(designer-v2): prevent false unsaved-changes flag in monitoring view
• Issue: None.
• Recommendation: The title is specific, uses a clear type/scope, and accurately describes the behavior change.

---

✅ Commit Type

• Properly selected (fix).
• Only one commit type is checked, which is correct.

---

⚠️ Risk Level

• The selected risk level is Low, which matches the label risk:low and the scope of the change.
• Advised risk level: low (no change needed).

---

✅ What & Why

• Current: Well written and specific, with clear root cause and fix description.
• Issue: None.
• Recommendation: This section already provides enough context for reviewers.

---

✅ Impact of Change

• Impact is clearly described for users, developers, and system behavior.
• Recommendation:
  • Users: No changes needed.
  • Developers: No changes needed.
  • System: No changes needed.

---

✅ Test Plan

• Unit tests were added/updated in the diff, and the PR body correctly reflects that.
• The presence of middleware.spec.ts updates satisfies the test plan requirement.

---

✅ Contributors

• @rllyy97 is listed.
• No issues found.

---

✅ Screenshots/Videos

• N/A is appropriate because this is a behavioral fix with no UI changes.

---

Summary Table

Section	Status	Recommendation
Title	✅	None
Commit Type	✅	None
Risk Level	✅	None
What & Why	✅	None
Impact of Change	✅	None
Test Plan	✅	None
Contributors	✅	None
Screenshots/Videos	✅	None

---

This PR passes. The submitted risk level matches the label and the body is well-formed.

---

Last updated: Thu, 02 Jul 2026 16:47:41 GMT

[Copilot]

Pull request overview

Fixes an intermittent “unsaved edits will be discarded” prompt that could appear after viewing run history (monitoring/read-only) by preventing false isDirty transitions from persisting in the designer Redux state. This aligns with the designer’s contract that monitoring view is read-only and should not create new unsaved-change signals.

Changes:

• Added monitoringDirtyGuardMiddleware to revert workflow.isDirty / workflowParameters.isDirty when they transition false → true during read-only or monitoring mode.
• Wired the new middleware into the designer store middleware chain.
• Added unit tests covering guarded dirty-flag transitions in read-only/monitoring scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
libs/designer/src/lib/core/utils/middleware.ts	Adds a Redux middleware that detects and reverts false-positive dirty-flag transitions in read-only/monitoring mode.
libs/designer/src/lib/core/utils/test/middleware.spec.ts	Adds unit tests validating the new middleware’s behavior.
libs/designer/src/lib/core/store.ts	Registers the new middleware in the store configuration.

[github-actions]

📊 Coverage Check

The following changed files need attention:

⚠️ libs/designer-v2/src/lib/core/store.ts - 40% covered (needs improvement)

Please add tests for the uncovered files before merging.