fix(vscode): Fix azure connectors prompt silent fail on startup#9361
Open
andrew-eldridge wants to merge 2 commits into
Open
fix(vscode): Fix azure connectors prompt silent fail on startup#9361andrew-eldridge wants to merge 2 commits into
andrew-eldridge wants to merge 2 commits into
Conversation
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | No change needed |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | No change needed |
| Contributors | ✅ | No change needed |
| Screenshots/Videos | Optional; not required for this non-visual change |
Passed: the PR title and body are compliant, and the submitted risk level matches the label and observed scope.
Last updated: Thu, 02 Jul 2026 15:39:31 GMT
…ureConnectorWizardFix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a VS Code extension startup issue where the Azure connectors wizard could silently fail due to connection key refresh running (and not being awaited) during activation. It removes connection key refresh from extension startup and confines it to pre-runtime/debug flows, reducing unexpected prompts at activation time.
Changes:
- Removed connection key refresh from extension activation and moved refresh to runtime/debug entry points.
- Refactored parameterization-on-load prompt logic and renamed the command entrypoint to clarify intent.
- Extracted the Logic App debug configuration provider into a shared utility and cleaned up related extension variables.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/vs-code-react/src/app/designer/appV2.tsx | Switches codeful-workflow flag lookup to a local settings key string. |
| apps/vs-code-designer/src/main.ts | Stops refreshing connection keys on activation; uses shared debug config provider and renamed parameterization entrypoint. |
| apps/vs-code-designer/src/extensionVariables.ts | Removes unused ext.codefulEnabled flag. |
| apps/vs-code-designer/src/app/utils/startRuntimeApi.ts | Refreshes connection keys immediately before starting the runtime API. |
| apps/vs-code-designer/src/app/utils/debug.ts | Introduces logicAppDebugConfigProvider to centralize debug configuration resolution logic. |
| apps/vs-code-designer/src/app/utils/codeless/common.ts | Uses non-null assertions for localSettings.Values when reading connector settings. |
| apps/vs-code-designer/src/app/utils/appSettings/localSettings.ts | Ensures Values is initialized when parsing local.settings.json; minor type tightening. |
| apps/vs-code-designer/src/app/utils/appSettings/connectionKeys.ts | Renames and narrows connection key logic to refreshConnectionKeys(projectPath) and updates telemetry naming. |
| apps/vs-code-designer/src/app/utils/appSettings/test/connectionKeys.test.ts | Updates unit tests to the renamed/narrowed connection key refresh behavior and removes obsolete scenarios. |
| apps/vs-code-designer/src/app/commands/pickFuncProcess.ts | Refreshes connection keys prior to debug attach/process selection flow. |
| apps/vs-code-designer/src/app/commands/parameterizeConnections.ts | Renames startup parameterization entrypoint and refactors decision/prompt logic. |
| apps/vs-code-designer/src/app/commands/test/pickFuncProcess.test.ts | Updates mocked connection key refresh function name and imports. |
Comment on lines
+37
to
+40
| const parameterizeConnectionsSetting = getGlobalSetting(parameterizeConnectionsInProjectLoadSetting); | ||
| if (parameterizeConnectionsSetting) { | ||
| return true; | ||
| } |
Comment on lines
+73
to
+75
| return undefined; | ||
| }, | ||
| } |
Comment on lines
+12
to
16
| * Refreshes the connection keys for the specified Logic App project, or all workspace projects by default. | ||
| * @param {IActionContext} context - The action context. | ||
| * @param {string} projectPath - The path to the Logic App project. If not provided, all Logic App projects in the workspace will be verified. | ||
| * @returns {Promise<void>} A promise that resolves when the verification is complete. | ||
| * @returns {Promise<void>} A promise that resolves when the refresh is complete. | ||
| */ |
Contributor
📊 Coverage CheckThe following changed files need attention:
Please add tests for the uncovered files before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
When refreshing connection keys on startup, if azure connectors configuration doesn't exist in local settings then user is prompted with the azureConnectorWizard. This ultimately results in azureConnectorWizard silently failing after 'Use connectors from Azure' is selected since connection keys refresh is unawaited on startup. This is confusing to the user who then has to restart connectors setup when opening designer or running workflow.
As a solution, removed connections key refresh from startup entirely- it is now only done prior to starting runtime, so there is no longer an azureConnectorWizard prompt on startup.
Impact of Change
Test Plan
Contributors
@andrew-eldridge