Conversation
No functional changes. Triggering a fresh validation run after rerun request did not start a new build.
Kavyareddyguntaka11
force-pushed
the
panderson/remove-old-drs-options
branch
from
September 14, 2026 17:34
fe9c38b to
71153cf
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The remaining Option allocation may cause invalid DRS configuration requests.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes legacy DRS option assignments while preserving existing DRS and vMotion behavior.
Changes:
- Stops setting
TryBalanceVmsPerHostandIsClusterManaged. - Retains existing DRS automation and vMotion rate configuration.
File summaries
| File | Summary |
|---|---|
Microsoft.AVS.Management/Microsoft.AVS.Management.psm1 |
Updates Set-CustomDRS; unresolved moderate issue: Option remains an array of null values and should be omitted or set to $null. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -718,12 +718,6 @@ function Set-CustomDRS { | |||
| $spec.DrsConfig.VmotionRate = $drsChange | |||
| $spec.DrsConfig.Enabled = $true | |||
| $spec.DrsConfig.Option = New-Object VMware.Vim.OptionValue[] (2) | |||
3 tasks
Contributor
|
Closing this PR because the legacy DRS cleanup, including removal of the unused Option array allocation, has been incorporated into #422. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TryBalanceVmsPerHostinSet-CustomDRSIsClusterManagedinSet-CustomDRSWhy
These legacy DRS options should no longer be applied when updating cluster DRS configuration.
Validation
tests/prevalidateModules.ps1 Microsoft.AVS.Managementgit diff --check origin/main...HEAD