fix: comprehensive workflow and build reliability fixes#411
Merged
Conversation
- Install InvokeBuild in build-psdocs job (was missing, causing failure) - Trust PSGallery in pipeline-deps.ps1 (avoids interactive prompts on CI) - Fix hashFiles glob: use /** pattern instead of directory path - Fix PSModulePath separator: use [IO.Path]::PathSeparator for cross-platform - Expand CI path filter to include root build files and scripts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Pass tag version to Invoke-Build via -Build parameter (was defaulting to 0.0.1 because version was extracted but never used) - Fix gh release create: remove --generate-notes (conflicts with --notes-file, gh rejects the combination) - Fix CHANGELOG path: use repo root CHANGELOG.md for psdocs-azure (packages/psdocs-azure/CHANGELOG.md doesn't exist) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ESLint ^9.x dropped support for .eslintrc.json and the --ext flag. npm run lint would fail on CI. - Create eslint.config.mjs (flat config format) - Add typescript-eslint and @eslint/js dependencies - Update lint script: remove --ext ts flag - Delete legacy .eslintrc.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix VSCE_PAT check: use secrets context instead of step-level env (step env not available at if: evaluation time) - Pin microsoft/ps-docs to SHA (was @main, supply chain risk) - Fix site_url in mkdocs.yml to actual published docs URL - Delete inert packages/psdocs/.github/workflows/build.yaml (GitHub ignores workflows outside root .github/workflows/) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vicperdana
force-pushed
the
fix/workflow-comprehensive-fixes
branch
from
0d239a9 to
d83e8c2
Compare
- Add .NET 7.0 to build-psdocs job (PSDocs subtree targets net7.0) - Regenerate package-lock.json after adding typescript-eslint and @eslint/js dependencies for ESLint 9 flat config migration Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The recommended presets added strict rules (no-require-imports, no-explicit-any, no-unused-vars, no-var, prefer-const) that the original .eslintrc.json did not enforce. Disable these to maintain parity with the subtree source code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Regenerate template README files to match test expectations (tests use New-PSDocumentOption without badge conventions, so committed READMEs must not include badge lines) - Remove @types/glob (incompatible with glob@11's bundled minimatch types; glob@11 has built-in TypeScript definitions) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vsce package rejects @types/vscode versions greater than engines.vscode. Pin @types/vscode to ~1.89.0 to match the extension's minimum VS Code engine requirement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BernieWhite
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all issues found in a comprehensive rubber-duck review of workflows and build scripts post-monorepo migration.
🔴 Blockers Fixed
build-psdocsjobci.ymlInstall-Modulecallsscripts/pipeline-deps.ps1-Build)release-psdocs.yml,release-psdocs-azure.ymlgh release createflag conflict (--notes-file+--generate-notes)release-psdocs-azure.yml.eslintrc.jsonunsupported)packages/vscode-extension/hashFilesglob (directory path →/**pattern)ci.ymlbuild/common.ps1🟡 Warnings Fixed
if:)vscode-ci.ymlmicrosoft/ps-docs@mainto SHAdocs.yamlsite_urlto actual published docs URLmkdocs.ymlci.ymlpackages/psdocs/.github/workflows/build.yamlCommits
Note on open PRs