remove leak check retries#341
Merged
Merged
Conversation
Mirrors the ctest change that dropped CTEST_RUN_TEST_SUITE_WITH_LEAK_CHECK_RETRIES. Both the ctest-mode and CppUnitTest-mode definitions are removed since the leak check now runs once at process exit and the macro had no remaining callers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR removes the RUN_TEST_SUITE_WITH_LEAK_CHECK_RETRIES macro from the unified test-runner abstraction header and updates contributor guidance to stop referencing it. This aligns the public API surface with current ctest capabilities (the underlying CTEST_RUN_TEST_SUITE_WITH_LEAK_CHECK_RETRIES macro does not exist in the vendored deps/ctest).
Changes:
- Remove
RUN_TEST_SUITE_WITH_LEAK_CHECK_RETRIESfrominc/testrunnerswitcher.h(bothUSE_CTESTandCPP_UNITTESTbranches). - Remove the corresponding usage example from
.github/copilot-instructions.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inc/testrunnerswitcher.h | Removes the leak-check-retry runner macro from the public abstraction header. |
| .github/copilot-instructions.md | Updates internal guidance/docs to no longer reference the removed macro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.