new Buffer -> Buffer.from

[Tony Brix (UziTech)]

from tjanczuk#636

---

new Buffer(string, encoding) is deprecated in Node v6
it changes to Buffer.from(string, encoding)

[Tony Brix (UziTech)]

any feedback on this?

[Curt Grimes (curtgrimes)]

Paul Batum (@paulbatum) Is this repo still being maintained?

[Tony Brix (UziTech)]

David Ebbo (@davidebbo) Ranjith Ramachandra (@rramachand21) can this get merged?

[Michael Szul (szul)]

Can we get a merger on this? The warning persistently ends up in the logs and makes debugging real issues harder.

[anantksingh]

How to fix below issue in nodev10
(node:14324) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

[Michael Szul (szul)]

anantksingh The fix is in this pull request, but it hasn't been merged yet.

[RockerOne (SuperstrongBE)]

It cause issue with https !
Please merge !

[Michael Szul (szul)]

RockerOne (@SuperstrongBE) You can find the file on your server and modify it yourself if you need a quick fix.

[Joe Early (JoeEarly)]

Tony Brix (@UziTech) when can this be merged? Fix has been tested so surely just click of a button now

[Tony Brix (UziTech)]

This is ready to be merged but I don't have push access and I don't think this repo is maintained.

[Tony Brix (UziTech)]

David Ebbo (@davidebbo) Ranjith Ramachandra (@rramachand21)

[David Ebbo (davidebbo)]

Sorry, I'm no longer at Microsoft, and neither is Ranjith. Ahmed ElSayed (@ahmelsayed) or Suwat Ch (@suwatch) do you know who owns this now?

[Michael Szul (szul)]

From the Microsoft mailing lists, it seemed like the App Service team keeps an eye on the repo (according to Stefan Schackow).

[Ahmed ElSayed (ahmelsayed)]

/cc JennyLawrance

[Dan Polivy (dpolivy)]

Ahmed ElSayed (@ahmelsayed) Any chance this can be merged and a release done, now that the changes are approved?

[Curt Grimes (curtgrimes)]

I think it's safe to say that this repo is no longer maintained.

[Joe Early (JoeEarly)]

Best thing to do is migrate away from IISNODE

[Djov (DjovDev)]

Best thing to do is migrate away from IISNODE

Do you have any alternatives as to run Node.JS in cooperation with IIS?

The only thing I can come up with right now is having multiple projects running using pm2 (https://www.npmjs.com/package/pm2) on different ports and having a reverse proxy rewrite rule on the websites in IIS (as documented on https://docs.microsoft.com/en-us/iis/extensions/url-rewrite-module/reverse-proxy-with-url-rewrite-v2-and-application-request-routing).

This is something I am in process of testing and I wonder how other people do it nowadays.

[Joe Early (JoeEarly)]

Best thing to do is migrate away from IISNODE

Do you have any alternatives as to run Node.JS in cooperation with IIS?

The only thing I can come up with right now is having multiple projects running using pm2 (https://www.npmjs.com/package/pm2) on different ports and having a reverse proxy rewrite rule on the websites in IIS (as documented on https://docs.microsoft.com/en-us/iis/extensions/url-rewrite-module/reverse-proxy-with-url-rewrite-v2-and-application-request-routing).

This is something I am in process of testing and I wonder how other people do it nowadays.

I ended up with pm2 running my expressjs apps and nginx as the web server. A bit of config needed but once I got it running its been very stable

[Lex Li (lextm)]

Djov (@DjovDev) HttpPlatformHandler has been a stable alternative from Microsoft since 2015, https://docs.lextudio.com/blog/running-nodejs-web-apps-on-iis-with-httpplatformhandler/