286 add dataset attachment to objects instead of collections when parsing#299
Open
LucasZimm wants to merge 12 commits into
Open
286 add dataset attachment to objects instead of collections when parsing#299LucasZimm wants to merge 12 commits into
LucasZimm wants to merge 12 commits into
Conversation
…tions-when-parsing' of https://github.com/BAMresearch/bam-masterdata into 286-add-dataset-attachment-to-objects-instead-of-collections-when-parsing
…d-of-collections-when-parsing
LucasZimm
added
feature
LucasZimm
added
fix
JosePizarro3
added
enhancement
Coverage Report for CI Build 26447443533Coverage remained the same at 0.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
JosePizarro3
approved these changes
May 27, 2026
| entity.save() | ||
| return entity | ||
|
|
||
| @property |
Member
There was a problem hiding this comment.
you can delete this property (self.datasets is already defined in pydantic)
| logger.error(f"Failed to commit object transaction: {e}") | ||
| return None | ||
|
|
||
| # TODO if later transactions support datasets change it to transaction. |
Member
There was a problem hiding this comment.
just cherrypicking: maybe add the date where you wrote this (e.g., " TODO (May 2026) ...")?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entities:
Parser:
Later Todo:
Fixed: