feat(react): add token, vault, proposal, and toast product components… - #1068
Open
aishagbadamosi wants to merge 3 commits into
Open
aishagbadamosi wants to merge 3 commits into
aishagbadamosi wants to merge 3 commits into
Conversation
|
@aishagbadamosi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ay#950) The forward-merge of main into feature/950-product-components interleaved two versions of the wallet-adapter signing path in sdk/src/vaultClient.ts (267 tsc errors) and two implementations of useVaultDeposit in react/src/hooks.ts (duplicate declarations, mangled useProposalVoting). - sdk/src/vaultClient.ts: restore main's canonical implementation, which already carries the optional-source wallet-adapter fallback. - react/src/hooks.ts: keep main's context-based useVaultDeposit / useProposalVote, re-add useVaultShareBalance (now takes a resolved VaultClient, keeping hooks.ts free of SDK runtime imports) and useProposalVoting; make Keypair a type-only import. - react/src/context.tsx: add useOptionalVaultClient for provider-less product component fallback. - react/src/components/VaultDepositWidget.tsx: build the client from props with provider fallback instead of a hooks-level useVaultClient. - react/src/hooks.test.tsx: add missing @testing-library/jest-dom import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (Closes #950)
What does this PR do?
Adds the six product components for the React package, so apps can build token, mint, vault, proposal, and transaction UX on top of the SDK instead of raw RPC. Closes #950.
Also enables browser-wallet signing for
VaultClientwrite calls (optionalsource, wallet-adapter fallback).Type of change
Checklist
pre-commit run --all-fileslocally and it passedBreaking changes?
Related issues
Closes #950