Celts labor api - #1771
Open
MImran2002 wants to merge 5 commits into
Open
Conversation
…e of the same key, considered edge cases if there are multiple position hold by a person and if the switch to a different position during spring which means we cannot display it as AY but as seperate spring and fall.
…studentstaff I have editted the side bar to allow someone who is studentstaff
sheggen
reviewed
Jul 27, 2026
| <option {{"selected" if g.current_user.username == config.default_user }} value="{{config.default_user}}">Default User: {{config.default_user}}</option> | ||
| <option {{"selected" if g.current_user.username == "ramsayb2"}} value="ramsayb2">Admin: ramsayb2</option> | ||
| <option {{"selected" if g.current_user.username == "neillz"}} value="neillz">Student Staff: neillz</option> | ||
| <option {{"selected" if g.current_user.username == "velazquezdiaza"}} value="velazquezdiaza">Student Staff: velazquezdiaza</option> |
Collaborator
There was a problem hiding this comment.
Does this work with our test data?
Collaborator
There was a problem hiding this comment.
Pick a different user, as this is exposing this user's labor and service records to our team.
Contributor
Author
There was a problem hiding this comment.
Will definitely work on it and the config for api as well.
Collaborator
There was a problem hiding this comment.
While we are here, we will be changing the language from "Student Staff" to "Program Manager" for this role. Later, we will add another role of "Operations Team" which has slightly elevated privileges from a PM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes issue #BCStudentSoftwareDevTeam/lsf#553
Changes
Images:
Before:
After:
Search Bar:
Testing
git checkout CELTSLaborInputandgit pulldatabase/reset_database.sh testand run the testtests/run_tests.shdatabase/reset_database.sh from-backupConnecting LSF and CELTS
Code example:
# lsfUrl = f"{app.config['lsf_url'].strip('/')}/api/org/2084"lsfUrl = "http://127.0.0.1:8989/api/org/2084"Testing the connection:
-From your CELTS run python3 app/scripts/import_labor_from_lsf.py this will pull the labor data from LSF. Now any approved form in LSF of the student will be pulled and it should display on CELTS. For the edge case like having new spring labor go ahead and create and approve the labor status form. Then run the import_labor_from_lsf.py script. It will pull the updated one and you will see the changes.
Testing the search bar
-Navigate to sidebar > student search and search either of these names "Emma M" or " Nyan Li" it will show those names.
Testing CCEMinor portal
-Navigate to sidebar > student search and search Cole Collins and go to his CCE Minor page. Copy the URL : http://127.0.0.1:8080/profile/collinsc2/cceMinor then switch to student ayisie and paste it.