Skip to content

Added EPW Comparison plots and execute commands#345

Open
Tom-Kingstone wants to merge 10 commits into
developfrom
LadybugTools_Toolkit-#218-CompareEPWs
Open

Added EPW Comparison plots and execute commands#345
Tom-Kingstone wants to merge 10 commits into
developfrom
LadybugTools_Toolkit-#218-CompareEPWs

Conversation

@Tom-Kingstone
Copy link
Copy Markdown
Contributor

@Tom-Kingstone Tom-Kingstone commented May 5, 2026

NOTE: Depends on

Issues addressed by this PR

Closes #218

Added EPW line and histogram comparison plots for EPW keys.
More plots can be added in future for more complex analysis but better to get a start on a couple for now and expand than try to do everything at once.

Plot information for EPW comparison is not yet implemented (plot information for many epw files is not yet implemented and it is not desirable to bloat return information with an individual plot information for each EPW file).

Also froze a few ladybug tools package versions to reduce docker image build times (dependency mapping in ubuntu is not done properly for some LBT packages)

Test files

Use the CompareEPWKeyPlotCommand with a LadybugToolsAdapter Execute and verify that both plot types can be created.

Changelog

  • Added EPW comparison line and histogram plots.
    • CompareEPWKeyPlotCommand execute command created for creating comparison plots

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this May 5, 2026
@Tom-Kingstone Tom-Kingstone added status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement labels May 5, 2026
@Tom-Kingstone Tom-Kingstone removed the status:WIP PR in progress and still in draft, not ready for formal review label May 5, 2026
@Tom-Kingstone
Copy link
Copy Markdown
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci Bot commented May 5, 2026

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci Bot commented May 5, 2026

@Tom-Kingstone fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 74412561058

@Tom-Kingstone
Copy link
Copy Markdown
Contributor Author

@BHoMBot fix copyright headers ref. 74412561058

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci Bot commented May 5, 2026

@Tom-Kingstone I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci Bot commented May 5, 2026

@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci Bot commented May 5, 2026

@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@Tom-Kingstone
Copy link
Copy Markdown
Contributor Author

That's not the right copyright header :/

Comment thread LadybugTools_Adapter/AdapterActions/Execute/CompareEPWKeyPlotCommand.cs Outdated
Comment thread LadybugTools_oM/ExecuteCommands/CompareEPWKeyPlotCommand.cs Outdated
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
@Tom-Kingstone
Copy link
Copy Markdown
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link
Copy Markdown

bhombot-ci Bot commented May 5, 2026

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Copy Markdown
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A spot check in GH shows that the new command appears to be functioning as required.

Please could you add DisplayText and Description attributes to the new command. In particular to clarify the difference between the EPWFile and the EPWCompareFiles.

Comment thread LadybugTools_oM/ExecuteCommands/CompareEPWKeyPlotCommand.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compare EPWs scripts

3 participants