Added EPW Comparison plots and execute commands#345
Conversation
…taking too long to resolve dependencies, and some fixes
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
|
@Tom-Kingstone fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
|
@BHoMBot fix copyright headers ref. 74412561058 |
|
@Tom-Kingstone I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you. |
|
@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made. |
|
@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
|
That's not the right copyright header :/ |
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
|
@BHoMBot check compliance |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
A spot check in GH shows that the new command appears to be functioning as required.
Please could you add DisplayText and Description attributes to the new command. In particular to clarify the difference between the EPWFile and the EPWCompareFiles.
NOTE: Depends on
Issues addressed by this PR
Closes #218
Added EPW line and histogram comparison plots for EPW keys.
More plots can be added in future for more complex analysis but better to get a start on a couple for now and expand than try to do everything at once.
Plot information for EPW comparison is not yet implemented (plot information for many epw files is not yet implemented and it is not desirable to bloat return information with an individual plot information for each EPW file).
Also froze a few ladybug tools package versions to reduce docker image build times (dependency mapping in ubuntu is not done properly for some LBT packages)
Test files
Use the
CompareEPWKeyPlotCommandwith aLadybugToolsAdapterExecute and verify that both plot types can be created.Changelog
CompareEPWKeyPlotCommandexecute command created for creating comparison plotsAdditional comments