chore(sdlc): ROADMAP #236 bloat-hunt — hooks, tests, ROADMAP archive#440
Merged
Conversation
Fable-led audit + Prove-It (TDD mutation-tested) pass across the three categories ROADMAP #236 flagged as not yet exercised: (b) hook noise: fixed codex-review-stop-check.sh delivering its Stop-hook nudge via stderr (invisible on exit 0 per CC hook-delivery semantics); fixed tdd-pretool-check.sh's hardcoded /src/ pattern missing this repo's own hooks/cli/.github/workflows source dirs via a new SDLC_TDD_SRC_PATTERN env override (keeps the CLI-distributed template generic); deleted goal-confidence-check.sh entirely (no cited incident, unproven value); trimmed precompact-seam-check.sh 256->101 lines (removed the untested .reviews/handoff.json self-heal branch); silenced model-effort-check.sh's unset-effort nagging; removed sdlc-prompt-check.sh's unfired #195 effort-bump detector; added 24h-cached CC-version checking to instructions-loaded-check.sh. (c) test redundancy: consolidated overlapping assertions across 10 test files; deleted tests/test-degradation-detection.sh outright (428 lines, fully superseded, 5 tests relocated into test-doc-consistency.sh); found and fixed a latent bug as a byproduct — test_ci_max_turns_sufficient in test-workflow-triggers.sh was defined twice, and the original (shadowed) definition was vacuous, always passing regardless of ci.yml content. (f) ROADMAP archive cut: split ROADMAP.md (326 lines / 182 rows) into a trimmed active table plus new ROADMAP_ARCHIVE.md holding 85 fully-resolved rows and 5 fully-archived release-history sections; added 3 row-completeness regression tests to test-doc-consistency.sh (mutation-verified) proving no row was silently dropped or duplicated. Cross-model reviewed (Codex xhigh, review_id 236-bloat-hunt-bcf-2026-07-06): round 1 found a real gate bypass in codex-gate-check.sh (a quoted flag value containing a space, e.g. git -c user.name="A B" commit, broke the git/commit structural match) — fixed and mutation-verified; round 2 CERTIFIED 10/10. All 58 test files pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fable-led audit + Prove-It (TDD mutation-tested) pass across the three ROADMAP #236 categories not yet exercised, time-boxed to Fable's free-inclusion window (closes 2026-07-07).
codex-review-stop-check.shwrote to stderr onexit 0, which Claude Code never surfaces), fixed a real dual-role-hook regression risk (tdd-pretool-check.sh's hardcoded/src/pattern via a newSDLC_TDD_SRC_PATTERNenv override, keeping the CLI-distributed template generic), deletedgoal-confidence-check.sh(unproven, no cited incident), trimmedprecompact-seam-check.sh256→101 lines (removed untested self-heal branch), quieted two other hooks' unproven nudges.tests/test-degradation-detection.shoutright (428 lines, fully superseded), and found+fixed a real latent bug as a byproduct:test_ci_max_turns_sufficientwas defined twice intest-workflow-triggers.sh, and the shadowed original was vacuous (always passed regardless ofci.ymlcontent).ROADMAP.md(326 lines/182 rows) into a trimmed active table + newROADMAP_ARCHIVE.md(85 fully-resolved rows + 5 release-history sections), with 3 new mutation-verified regression tests proving no row was silently dropped or duplicated.Cross-model reviewed with Codex (xhigh): round 1 found a real gate bypass in
codex-gate-check.sh— a quoted config value containing a space, passed to a-cflag ahead of the commit subcommand, broke the structural detection regex. Fixed and mutation-verified. Round 2 CERTIFIED 10/10.Test plan
tests/test-*.shfiles pass (bash tests/test-<name>.shexit 0 each).claude/settings.jsonre-validated as JSON after edits