Ignore fvm files - #1042
Open
rickdijk wants to merge 1 commit into
Open
Ignore fvm files#1042rickdijk wants to merge 1 commit into
rickdijk wants to merge 1 commit into
Conversation
fvm is a local SDK manager some maintainers use. CI installs Flutter directly and nothing here requires it, so a pinned SDK should never be committed. flutter_cache_manager already ignores these; this repo did not, so a stray `fvm use` would have checked one in. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Repository hygiene. Two lines in
.gitignore, nothing else..fvmrcand.fvm/are not ignored. fvm is a local SDK manager some maintainers use; nothing in this repository requires it, and CI does not use it. The workflows install Flutter withsubosito/flutter-action@v2on the stable channel.That means the first time someone runs
fvm usein a clone here, the resulting.fvmrcshows up as an untracked file and can be committed by accident. One maintainer's local SDK choice would then become everyone's, including contributors who do not have fvm installed.Baseflow/flutter_cache_manageralready ignores both paths. This repository andBaseflow/octo_imagedid not.🆕 What is the new behavior (if this is a feature change)?
.fvmrcand.fvm/are ignored, added to the Miscellaneous block to match whereflutter_cache_managerhas them. A local SDK pin stays local.💥 Does this PR introduce a breaking change?
No. Neither path exists in this repository today, so nothing is removed from tracking and no working tree changes.
🐛 Recommendations for testing
git check-ignore -v .fvmrc .fvm/flutter_sdkmatches both rules.git statusis unchanged for anyone without fvm.📝 Links to relevant issues/docs
Linear FPL-10. Same change in
Baseflow/octo_imageunder FPL-11, andBaseflow/flutter_cache_managerPR 524 removes the matching docs that presented fvm as a requirement.🤔 Checklist before submitting
🤖 Generated with Claude Code