fix(security): bump cryptography to 50.0.0 — clears 3 CVEs failing the Security Scan - #16
Open
BasitS-hash wants to merge 1 commit into
Open
fix(security): bump cryptography to 50.0.0 — clears 3 CVEs failing the Security Scan#16BasitS-hash wants to merge 1 commit into
BasitS-hash wants to merge 1 commit into
Conversation
pip-audit in the Security Scan workflow has been failing on main since the advisories landed: cryptography 48.0.1 PYSEC-2026-3552 fix 50.0.0 cryptography 48.0.1 PYSEC-2026-3553 fix 49.0.0 cryptography 48.0.1 PYSEC-2026-3554 fix 49.0.0 This library performs the AEAD encryption backing the zero-knowledge store, so these are in the most sensitive dependency in the project. 50.0.0 is the lowest version clearing all three (3553 and 3554 are fixed in 49.0.0, but 3552 requires 50.0.0), so a single bump resolves the set. Verified: pip-audit -r requirements.txt --strict reports no known vulnerabilities; full suite passes (59 passed, 12 skipped).
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Security Scan workflow has been red on
main.pip-auditis flagging three advisories incryptography:This is the library performing the AEAD encryption behind the zero-knowledge store — the most security-critical dependency in the project.
The fix
cryptography==48.0.1→cryptography==50.0.0.50.0.0is the lowest version that clears all three: 3553 and 3554 are fixed in 49.0.0, but 3552 needs 50.0.0. One bump resolves the set rather than leaving a partial fix.Verification
Crypto and JWT security suites (
test_crypto.py,test_crypto_security.py,test_jwt_security.py) all pass against the new version, so no API surface changed.