🐛 fix message customisation for sf 8#70
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to restore/customize the Recaptcha2 constraint message in a Symfony 8-compatible way (named arguments), as requested in issue #69, while also updating CI/static analysis configuration.
Changes:
- Added a custom constructor to
Recaptcha2constraint intended to supportmessage:named argument usage and deprecate array-based options. - Adjusted CI workflow to use
ramsey/composer-installand updated PHPStan invocation. - Removed the PHPStan baseline include and made minor config formatting updates.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/Validator/Constraints/Recaptcha2.php |
Adds a constructor intended to support named-arg message customization and deprecate array options. |
src/DependencyInjection/Configuration.php |
Removes an inline PHPStan ignore comment / minor formatting cleanup. |
phpstan.neon |
Removes baseline include (now only sets paths/level). |
composer.json |
Adds a conflict rule for google/recaptcha 1.5.0. |
.github/workflows/build.yaml |
Updates CI steps (checkout version, PHPStan image tag pinning removed, new dependency installation approach). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #69