feat: Beckman Coulter PharmSpec - add container id to the sample custom document - #1253
Open
slopez-b wants to merge 1 commit into
Open
feat: Beckman Coulter PharmSpec - add container id to the sample custom document#1253slopez-b wants to merge 1 commit into
slopez-b wants to merge 1 commit into
Conversation
slopez-b
changed the title
There was a problem hiding this comment.
Pull request overview
This PR extends the Beckman Coulter PharmSpec parser’s sample-level custom information by including a container ID, and updates the expected JSON fixtures to reflect the new custom information document content under each sample document.
Changes:
- Add
container_identifierto the parsed header data model and propagate it intosample_custom_info. - Populate sample custom information with
"container identifier"(when present) for each measurement/run. - Update PharmSpec golden JSON test fixtures to include the new sample custom information document content.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/allotropy/parsers/beckman_pharmspec/beckman_pharmspec_structure.py |
Parses “Container ID” into the header and emits it into the sample custom information document. |
tests/parsers/beckman_pharmspec/testdata/hiac_example_6.json |
Updates expected output to include "container identifier" under the sample custom information document for each run. |
tests/parsers/beckman_pharmspec/testdata/hiac_example_7.json |
Updates expected output to include "container identifier" under the sample custom information document for each run. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
119
to
121
| sample_identifier=data[str, ("Probe", "Sample Name")], | ||
| container_identifier=data.get(str, "Container ID"), | ||
| dilution_factor_setting=data[float, "Dilution Factor"], |
slopez-b
force-pushed
the
slopez/add-container-id-bechman-pharmspec
branch
from
August 14, 2026 20:21
aab496e to
1ee07ad
Compare
james-leinas
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.