Release 2.1.0 - #17
Merged
Merged
Conversation
The floating jitpack snapshot v1.21-SNAPSHOT resolves to an ephemeral git-described build whose jar/POM get evicted, breaking CI even on unchanged commits. Switch to the equivalent stable Maven Central coordinates (org.mockbukkit.mockbukkit:mockbukkit-v1.21:4.110.0). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TopBlock now hooks into AOneBlock, ChunkBlock, or both, keeping a separate top ten, command, and placeholder set per game mode. - New hooks package: TopBlockHook interface with AOneBlockHook and ChunkBlockHook implementations. These are the only classes that reference their game mode's packages, so a game mode that is not installed is never class-loaded. - TopBlock.onEnable hooks each supported game mode that is present and enabled, registering a topblock subcommand on each player command; it disables itself only if neither game mode is found. - TopBlockManager keeps one top ten list per hook; the refresh task updates all of them. - PlaceholderManager registers island_*_top_1..10 placeholders once per hook, scoped to that game mode's addon, so %aoneblock_...% and %chunkblock_...% stay separate. - addon.yml: depend AOneBlock -> softdepend AOneBlock, ChunkBlock; add chunkblock.island.topblock and chunkblock.intopten permissions. - pom.xml: add chunkblock 1.0.1 (provided) and level 2.6.2 (test only, needed to mock ChunkBlock which hard-depends on Level). - Tests: hook selection scenarios, per-hook top ten separation, world-to-hook resolution, per-game-mode placeholder registration, and unit tests for both hook implementations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UtAC44orba7UkTpFwHEw22
Add ChunkBlock support alongside AOneBlock
Follow-up to the 2.1.0 pom bump, which left the CLAUDE.md note stale. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UtAC44orba7UkTpFwHEw22
Update CLAUDE.md build version reference to 2.1.0
Both AOneBlock and ChunkBlock use OneBlockIslands as their database class name. BentoBox's JSON handler keys on getSimpleName(), so both game modes share the same database/OneBlockIslands/ folder. When TopBlock refreshes ChunkBlock's data, handler.loadObjects() returns all records including AOneBlock's, causing AOneBlock players to appear in the ChunkBlock panel. Fix by filtering islands in refresh() with hook.getGameMode().inWorld(island.getWorld()) so only islands belonging to the correct game mode are included. Also guard the panel icon path against customised templates where icon: PLAYER_HEAD is uncommented — builder.icon(ItemStack) does not set playerHeadName, so HeadGetter was never invoked and heads stayed as Steve. Additionally, catch LinkageError in onEnable() when constructing game mode hooks, and add softdepend entries in plugin.yml for the Pladdon plugin names so class loading works across plugin loaders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WwpMcJAhXEWeFwtRwg1uNy
Fix ChunkBlock top ten showing AOneBlock players
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.1.0
Changes since 2.0.0
topblocksubcommand, and placeholder set (%aoneblock_...%/%chunkblock_...%). [PR #14]OneBlockIslandsdatabase table (BentoBox keys on class simple name). Added a world filter so each game mode's top ten only includes its own islands. Also fixed Steve heads when template icon is PLAYER_HEAD, and added Pladdon softdepend + LinkageError resilience. [PR #16]Checklist