Bug 4382: "Detect/document ucx-conduit native kinds when UCX build lacks GDR support".#10
Draft
PHHargrove wants to merge 1 commit into
Draft
Bug 4382: "Detect/document ucx-conduit native kinds when UCX build lacks GDR support".#10PHHargrove wants to merge 1 commit into
PHHargrove wants to merge 1 commit into
Conversation
This commit resolves the "detect" aspect of Bug 4382: "Detect/document ucx-conduit native kinds when UCX build lacks GDR support". As agreed in the bug report, `gex_MK_Create` will now return a non-fatal `GASNET_ERR_BAD_ARG`. A well written client can potentially recover by falling back to use of some non-kinds comms. In the future, however, GASNet-EX would ideally fall back to a reference implementation which would "do the right thing" transparently. Example output from process 0 in a run of `testcudauva` on a system with CUDA GPUs, but lacking CUDA support in the UCX library: ``` *** WARNING (proc 0): GASNet gasnetc_mk_create_hook returning an error code: GASNET_ERR_BAD_ARG (Invalid function parameter passed) at /[REDACTED]/gasnet/ucx-conduit/gasnet_kinds.c:93 reason: Requested device memory type is not supported in the UCX library ERROR calling: gex_MK_Create(&kind, myclient, &args, 0) at: /[REDACTED]/gasnet/tests/testcudauva.c:203 error: GASNET_ERR_BAD_ARG (Invalid function parameter passed) ```
Collaborator
Author
|
See https://bitbucket.org/berkeleylab/gasnet/pull-requests/517 for prior history of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is "DRAFT" pending at least
TO DO:
This work has only been tested with respect to CUDA. So HIP (on both NVIDIA and AMD hardware) and ZE kinds support need to be tested before this can be considered ready for merge.
ucx: check memory kinds support at MK_Create time
This commit resolves the "detect" aspect of Bug 4382: "Detect/document ucx-conduit native kinds when UCX build lacks GDR support".
As agreed in the bug report,
gex_MK_Createwill now return a non-fatalGASNET_ERR_BAD_ARG. A well written client can potentially recover by falling back to use of some non-kinds comms. In the future, however, GASNet-EX would ideally fall back to a reference implementation which would "do the right thing" transparently.Example output from process 0 in a run of
testcudauvaon a system with CUDA GPUs, but lacking CUDA support in the UCX library: