Draft
Conversation
ceeb805 to
0225fe9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 89.64% 89.73% +0.08%
==========================================
Files 48 48
Lines 13226 13226
==========================================
+ Hits 11857 11868 +11
+ Misses 1369 1358 -11 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
run_simulatorsworkflow to use GitHub OIDC and AWS SSM instead of long-lived AWS access keys, SSH keys, and a GitHub access token. The workflow now assumes an AWS role with short-lived credentials, sends remote commands through SSM, and checks out the exact workflow commit by SHA.Note: CARLA tests are still failing, but I reproduced the same failure manually on the EC2 instance outside of GitHub Actions/SSM. The logs point to a separate CARLA/UE4 memory/runtime issue, not the workflow security changes.
Issue Link
Checklist
pytestand/or other meansAdditional Notes