Conversation
4 tasks
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
Comment on lines
+1121
to
+1130
| if length is None: | ||
| domain.flattenOnto(value, flattened) | ||
| else: | ||
| fixedDomain = feature.fixedDomains(self.timeBound)[length] | ||
| fixedDomain.flattenOnto(value, flattened) | ||
| if fixedDimension: | ||
| sizePerElt = domain.flattenedDimension | ||
| needed = (feature.maxLength - length) * sizePerElt | ||
| for i in range(needed): | ||
| flattened.append(None) |
Collaborator
There was a problem hiding this comment.
Can we pull this code out into a helper function (can be local, doesn't need to be a method on the class) and use it in the loop for static features too? Most of the code is identical.
Collaborator
There was a problem hiding this comment.
(We can leave this to later, it's not that important)
dfremont
reviewed
Dec 16, 2025
dfremont
reviewed
Dec 16, 2025
| dim += 1 # Timesteps | ||
| for feature in self.features: | ||
| domain = feature.domain | ||
| timeMult = self.timeBound if isinstance(feature, TimeSeriesFeature) else 1 |
Collaborator
There was a problem hiding this comment.
A thought probably best left for later: maybe we should move all the flattening logic into new Feature._flatten and Feature._flattenedDimension methods. Then this kind of case split could be handled by overrides in TimeSeriesFeature instead of needing to have special cases here.
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Dec 17, 2025
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
Eric-Vin
commented
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 16, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
dfremont
reviewed
Apr 17, 2026
Eric-Vin
commented
Apr 22, 2026
Eric-Vin
commented
Apr 22, 2026
Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dynamic sampling to VerifAI.
Merge with BerkeleyLearnVerify/Scenic#417