[codex] Fix marketplace paths on non-Windows platforms#1448
Draft
bc19sam-afk wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
\\?\extended-path behavior on Windows\\?\/Users/...-style paths on UnixRoot cause
windows_extended_path()was used unconditionally when writing local marketplace sources. On macOS this converted paths such as:into:
The resulting path does not point to the marketplace directory on macOS, so Codex reports that the marketplace root has no supported manifest. The comparison logic also stripped the prefix on every platform, which prevented Codex++ from repairing already-malformed non-Windows entries.
Related to #1169.
Impact
After this change, launching Codex++ or repairing the plugin marketplace no longer corrupts marketplace paths on macOS/Linux. Existing malformed paths are corrected on the next marketplace configuration pass. Windows behavior remains unchanged.
Validation
cargo fmt --all -- --checkgit diff --checkcargo test -p codex-plus-core plugin_marketplace::tests— 12 passedcargo test -p codex-plus-core --lib— 113 passedThe broader
cargo test -p codex-plus-corerun reaches an unrelated existing failure incodex_process_filter_keeps_chatgpt_desktop_package_processes. The same failure reproduces on an unmodifiedupstream/mainworktree.