fix(watcher): add ChatGPT-Desktop to APP_PACKAGE_SPECS#1450
Open
lennney wants to merge 1 commit into
Open
Conversation
Owner
|
当前 PR 的 Windows artifacts 检查失败。另外， |
The watcher tests added in ffac508 expect OpenAI.ChatGPT-Desktop to be recognized as a valid Codex Windows package, but APP_PACKAGE_SPECS only listed OpenAI.Codex and OpenAI.CodexBeta. This caused two watcher tests to fail on Windows: - codex_process_filter_keeps_chatgpt_desktop_package_processes - find_codex_processes_combines_store_and_local_installs Add OpenAI.ChatGPT-Desktop with the same app structure as the existing entries.
lennney
force-pushed
the
fix/watcher-chatgpt-desktop-package
branch
from
ae998a8 to
38bcfe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two watcher tests fail on Windows since v1.2.33:
Root cause: Commit
ffac508added tests expectingOpenAI.ChatGPT-Desktopto be recognized as a Windows Codex app package. The tests look up the process inAPP_PACKAGE_SPECS, but the spec entry was never added —app_paths.rsonly knew aboutOpenAI.CodexandOpenAI.CodexBeta.This affects all PRs on
upstream/mainincluding upstream's own CI.Fix
Add
OpenAI.ChatGPT-DesktoptoAPP_PACKAGE_SPECSwith the same app structure as its siblings.Impact: +6 lines, no behavioral change to production code. Fixes 2 tests and unblocks Windows CI for the main branch and all open PRs.