fix: repair Windows portable launch and manager activation#1482
Open
chrichuang218 wants to merge 1 commit into
Open
fix: repair Windows portable launch and manager activation#1482chrichuang218 wants to merge 1 commit into
chrichuang218 wants to merge 1 commit into
Conversation
Prefer the real ChatGPT desktop entrypoint for portable bundles, improve portable version detection, and restore the existing manager window when its shortcut is launched again.\n\nAdds regression coverage for portable paths and Windows main-window selection.\n\nRefs BigPizzaV3#1481 and BigPizzaV3#1187.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatGPT.exeover theCodex.exeshim in standalone/portable Windows bundlescurrentlinks, andversionfilesRoot cause
Recent portable Codex desktop bundles can contain both
Codex.exeandChatGPT.exe. The former behaves as a shim and does not preserve the Chromium remote-debugging arguments required by Codex++, so the helper starts while CDP remains unavailable.The manager also returned immediately on a single-instance guard conflict without activating the existing window. When hidden to the tray, generic window enumeration could target helper or IME windows instead of the Tauri main window.
Impact
Portable Windows installations launch the actual Codex desktop process with CDP enabled, report a meaningful version, and allow users to reopen a hidden manager through the desktop shortcut.
Validation
cargo fmt --checkcargo test --all-featurescargo test -p codex-plus-core windows_integration::tests::application_window_outranks_titled_ime_and_tool_windows -- --exactcargo test -p codex-plus-core --test launcher app_paths(22 passed)cargo test -p codex-plus-manager --test windows_subsystem(22 passed)Codex.exedid not expose CDP;ChatGPT.exedidcargo clippy --all-targets --all-features -- -D warningsstill reports 96 pre-existing warnings across the upstream baseline; no unrelated Clippy cleanup is included here.Fixes #1481
Fixes #1187