Skip to content

Fix deterministic caring-contact time test #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 1 commit into from
Aug 30, 2026
+5 −7
Merged

Fix deterministic caring-contact time test #2465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions tests/caring-contacts-contact-time-adjustment.dom.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// HTTP boundary: `route.ts` imports `server-only` and `next/headers`, and it has its own suite in
// `tests/caring-contacts-contact-route.test.ts`, which asserts the same refusals against the real
// handler.
import { act, cleanup, render, screen, waitFor } from "@testing-library/react";
import { act, cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { PLAN_ASSURANCE_VALUES } from "@/lib/caring-contacts/assurances";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
Expand Down Expand Up @@ -328,8 +328,7 @@ describe("moving one contact within its day", () => {
await waitFor(() => expect(outcomeText()).toContain("11:30 AWST"));

// The second move, with no server render in between.
await userEvent.clear(timeField());
await userEvent.type(timeField(), "15:45");
fireEvent.change(timeField(), { target: { value: "15:45" } });
await openOverlay();
await userEvent.click(overlayAction());
await waitFor(() => expect(outcomeText()).not.toBe(""));
Expand Down Expand Up @@ -374,8 +373,7 @@ describe("moving one contact within its day", () => {
expect(toAwstParts((await contactUnderTest(store)).planned.sendAt)).toMatchObject({ hour: 11, minute: 30 });
const afterFirst = await contactUnderTest(store);

await userEvent.clear(timeField());
await userEvent.type(timeField(), "15:45");
fireEvent.change(timeField(), { target: { value: "15:45" } });
await openOverlay();
const beforeSecond = requested.length;
await userEvent.click(overlayAction());
Expand Down Expand Up @@ -697,8 +695,8 @@ describe("a time this service may not send at", () => {
act(() => window.history.back());
await waitFor(() => expect(openOverlayId()).toBeNull());

await userEvent.clear(timeField());
await userEvent.type(timeField(), "18:00");
// A time control emits one completed browser change; typing partial values makes jsdom sanitise it to "".
fireEvent.change(timeField(), { target: { value: "18:00" } });
await openOverlay();
expect(openOverlayId()).toBe("outside-window-warning");
});
Expand Down
Loading