Register WebSocket route under the path prefix too#89
Merged
Conversation
Some nginx-ingress configurations don't preserve the WebSocket
``Upgrade`` header when ``rewrite-target`` is active -- the upgrade
becomes a plain HTTP GET by the time it reaches uvicorn, so the
``@APP.websocket('/ws')`` route never matches and FastAPI returns 404.
The companion fix is a separate ingress that routes ``/<prefix>/ws`` to
the monitor service *without* rewrite-target, so the Upgrade headers
pass through. This commit registers the WS handler at the prefixed
path as well, so the route table matches regardless of whether the
ingress rewrote the path.
Local dev (no MONITOR_ROOT_PATH) only adds the bare ``/ws`` entry.
Codecov Report❌ Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some nginx-ingress configurations don't preserve the WebSocket
Upgradeheader whenrewrite-targetis active -- the upgrade becomes a plain HTTP GET by the time it reaches uvicorn, so the@APP.websocket('/ws')route never matches and FastAPI returns 404.The companion fix is a separate ingress that routes
/<prefix>/wsto the monitor service without rewrite-target, so the Upgrade headers pass through. This commit registers the WS handler at the prefixed path as well, so the route table matches regardless of whether the ingress rewrote the path.Local dev (no MONITOR_ROOT_PATH) only adds the bare
/wsentry.