Skip to content

Fix bug for reactor batch calculation. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoelcortes merged 2 commits into from
Jul 7, 2026
Merged

Fix bug for reactor batch calculation. #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
465192d
fix bug for when `loading_time` is None but `N_reactors` is given
yalinli2 Jul 6, 2026
b40addd
remove redundant lines
yalinli2 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions biosteam/units/design_tools/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ def f(tau_loading):
N_reactors = ceil(F_vol * (tau_reaction + tau_cleaning + tau_loading) / (V_max * V_wf))
V_T = F_vol * (tau_reaction + tau_cleaning + tau_loading)
V_i = V_T / N_reactors
# Total volume of all reactors, assuming no downtime
V_T = F_vol * (tau_reaction + tau_cleaning) / (1 - 1 / N_reactors)
# Volume of an individual reactor
V_i = V_T / N_reactors
# Time required to load a reactor
tau_loading = V_i / F_vol

# Total volume of all reactors, assuming no downtime
V_T = F_vol * (tau_reaction + tau_cleaning) / (1 - 1 / N_reactors)

# Volume of an individual reactor
V_i = V_T / N_reactors

# Time required to load a reactor
tau_loading = V_i / F_vol
else:
tau_loading = loading_time

Expand Down
Loading